Skip to content
This repository has been archived by the owner on Sep 21, 2023. It is now read-only.

Rework transcription detection #326

Open
TimJentzsch opened this issue Apr 3, 2022 · 0 comments
Open

Rework transcription detection #326

TimJentzsch opened this issue Apr 3, 2022 · 0 comments
Labels

Comments

@TimJentzsch
Copy link
Contributor

To search a transcription, the bot currently first tries to look for it in the comment forest of the submission. This can take a lot of API requests and seems to be unreliable sometimes. Afterwards, the bot will check the user's profile.

I propose that we immediately use the user's profile to find the transcription. This has several advantages:

  • Less code to maintain (and the comment forest API is not really easy to use)
  • More consistent
  • Less comments to search, one API request will be enough
  • If the user didn't include the footer link, but made a comment on a post, we can suggest to recheck the formatting guidelines

Of course we will have to make sure only transcriptions on the actual submission are picked up. We will also have to make sure that multi-comment transcriptions are handled correctly.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

1 participant