Add tooltip documentation to web request, text, and brush nodes #3427
+22
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add descriptive tooltips to web request nodes (GET/POST, string/image conversion, resource loading, image decoding) - Add tooltip to GPU rasterization node explaining footprint usage - Improve text node tooltip with clearer per_glyph_instances parameter explanation - Add tooltips to brush stamp generator and blit operations explaining their internal roles - Fix typos in tooltip and variable names (it's→its, perview→preview, instnace→instance)
Keavon
reviewed
Nov 27, 2025
TrueDoctor
reviewed
Nov 27, 2025
Keavon
reviewed
Nov 27, 2025
Keavon
reviewed
Nov 27, 2025
| Arc::new(editor.application_io.as_ref().unwrap().create_window()) | ||
| } | ||
|
|
||
| /// "Discard Result" runs asynchronously in the background without waiting. Useful for triggering webhooks or analytics without blocking. |
Member
There was a problem hiding this comment.
This should describe the parameter, not the whole node.
Author
There was a problem hiding this comment.
I hope that is better now. My 'brain' had reached its weekly token limit
… about per_glyph_instances. Can it be 3 lines?
Member
|
@PolyglotOpenstreetmap can you address the remaining comments? |
Change doc comment to describe the node's purpose rather than focusing only on the "Discard Result" parameter. Now clearly states this is an HTTP POST operation with optional async behavior.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #