Skip to content

Searching on product fields doesn't work since GV 2.22 #2063

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
rafaehlers opened this issue May 24, 2024 · 2 comments
Closed

Searching on product fields doesn't work since GV 2.22 #2063

rafaehlers opened this issue May 24, 2024 · 2 comments
Assignees
@doekenorg
Labels
Bug
Milestone
2.24

Comments

@rafaehlers
Copy link
Contributor

You can replicate that here: https://debug.try.gravitykit.com/view/product-radio/

Rolling back GV to 2.21.2 works.

Might be related: #2020

  • Range-based search for Number, Product (user-defined price), Quantity and Total fields in the Search Bar.
@rafaehlers rafaehlers added the Bug label May 24, 2024
@rafaehlers
Copy link
Contributor Author

https://secure.helpscout.net/conversation/2606163600/54716

@doekenorg doekenorg mentioned this issue May 27, 2024
Merged
mrcasual added a commit that referenced this issue May 27, 2024
@mrcasual
Fix product field search with text (#2064)
0676637 
This PR Addresses #2063 

The check only looked for product fields, but did not take into account
it could just be searching for a text. When using a Range, the filters
are set to `is_numeric`. This is now added to the check to be sure it
still searches on text too.

Tests added to prevent future regression.

💾 [Build
file](https://www.dropbox.com/scl/fi/9i1s1ocvommim4tkhcy40/gravityview-2.23-6bfe2cd5d.zip?rlkey=ueaiujhl48craxg5qvrxvbpo7&dl=1)
(6bfe2cd).
@mrcasual mrcasual added this to the 2.24 milestone May 27, 2024
@rafaehlers
Copy link
Contributor Author

I tested the PR and already installed it on the affected user. No need to notify it again later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@doekenorg doekenorg

Labels
Bug
Projects
None yet
Milestone
2.24
Development

No branches or pull requests
3 participants
@doekenorg @rafaehlers @mrcasual