Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delta's return inversed value #528

Open
GregHib opened this issue Apr 30, 2024 · 1 comment
Open

Delta's return inversed value #528

GregHib opened this issue Apr 30, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@GregHib
Copy link
Owner

GregHib commented Apr 30, 2024

val tile = Tile(100, 100)
val other = Tile(105, 106)
val delta = tile.delta(other)
assertEquals(Delta(5, 6), delta)

The delta from tile1 -> tile2 is returning the negative delta instead of the positive. That is to say x1-x2 not x2-x1.

Will need to flip all existing usages

@GregHib GregHib added the bug Something isn't working label Apr 30, 2024
@GregHib
Copy link
Owner Author

GregHib commented May 3, 2024

There's no reason it has to be one way or another, might it make more sense the other way though? Hard to say

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant