Skip to content

Commit dd6200c

Browse files
committed
Add ConfigureAwait whose purpose wasn't so clear. It has to be done since the call to OnCompleted ends up in ManualResetValueTaskSourceCore which does indeed care for the configuration.
1 parent 8f88a22 commit dd6200c

File tree

1 file changed

+1
-4
lines changed

1 file changed

+1
-4
lines changed

src/Providers.Core/Factory/WebSocketGremlinqClientFactory.cs

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -125,10 +125,7 @@ public async IAsyncEnumerator<ResponseMessage<T>> GetAsyncEnumerator(Cancellatio
125125
{
126126
await using (ct.Register(Dispose))
127127
{
128-
//TODO: Should ConfigureAwait be called ?
129-
#pragma warning disable CA2007 // Consider calling ConfigureAwait on the awaited task
130-
if (await new ValueTask<ResponseAndQueueUnion<T>?>(this, 0) is { } union)
131-
#pragma warning restore CA2007 // Consider calling ConfigureAwait on the awaited task
128+
if (await new ValueTask<ResponseAndQueueUnion<T>?>(this, 0).ConfigureAwait(false) is { } union)
132129
{
133130
if (union.TryGetResponse(out var response))
134131
yield return response;

0 commit comments

Comments
 (0)