Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

readme example needs to "start()" the listener #22

Open
john-devseek opened this issue Oct 14, 2021 · 1 comment
Open

readme example needs to "start()" the listener #22

john-devseek opened this issue Oct 14, 2021 · 1 comment

Comments

@john-devseek
Copy link

In the example demonstrating usage of QueueHandler and QueueListener, the listener is instantiated with the following line in the example:
logging.handlers.QueueListener(queue, handler_loki)

Looking at the source code, the thread handling the queue is not instantiated or started until start() is called (so __init__ is not enough).

@parity3
Copy link

parity3 commented Oct 14, 2021

Also, it seems a bit confusing you'd be using a Queue from multiprocessing instead of threading, without actually using processes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants