Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM] Restrict PM Access to Sponsors with Prizes #99

Open
andrewdimmer opened this issue Mar 15, 2021 · 0 comments
Open

[PM] Restrict PM Access to Sponsors with Prizes #99

andrewdimmer opened this issue Mar 15, 2021 · 0 comments
Labels
API For work on the API bug Something isn't working Prize Module (PM) For all work pertaining to the Prize Module (PM) unallocated Currently not allocated to someone to work on Web App For work on the main web app

Comments

@andrewdimmer
Copy link
Contributor

Describe the bug
Currently, any sponsor is able to preform actions on the Prize Module provided that the companyId of the prize matches the companyId of the SPONSOR user who creates that prize. Then, all of the approval process for the prize is done by the organizer team, who will need to manually reject any prizes created by sponsors that don't have prizes as a sponsor benefit.

Expected behavior
Not all sponsors have prizes, so the PM should be restricted to only include sponsors that have prizes based on the benefits listed for them in the STPM (as exposed by #25 ). This will also likely require a breaking change to the STMP data type to define more information about prizes regarding things like the number of prizes, in addition to the total budget as it is designed now.

Additional context
Additional thought will be required to figure out the edge case where the sponsor prize benefits change after prizes have been created though, however, which is the reason this issue has been moved to unallocated.

@andrewdimmer andrewdimmer added bug Something isn't working API For work on the API Web App For work on the main web app Prize Module (PM) For all work pertaining to the Prize Module (PM) unallocated Currently not allocated to someone to work on labels Mar 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API For work on the API bug Something isn't working Prize Module (PM) For all work pertaining to the Prize Module (PM) unallocated Currently not allocated to someone to work on Web App For work on the main web app
Projects
None yet
Development

No branches or pull requests

1 participant