Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Time and date issue Resolved when updating #62

Merged
merged 5 commits into from
Oct 12, 2024
Merged

Time and date issue Resolved when updating #62

merged 5 commits into from
Oct 12, 2024

Conversation

Anurag519Narula
Copy link
Contributor

Description

Fixed the issue to update time and date fields after updating an item

Fixes #50

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

@Anshgrover23
Copy link
Collaborator

@Anurag519Narula Have you test the changes? kindly share before and after video.

@Anurag519Narula
Copy link
Contributor Author

Anurag519Narula commented Oct 12, 2024 •
edited
Loading

Yeah sure, I have checked the changes, here is the video attached after my changes. @Anshgrover23

Final.mp4

The error is coming because of lint error that i guess everyone is facing, I'll take the pull once that issue is fixed.

@Anshgrover23
Copy link
Collaborator

@Anurag519Narula nice work! can u try to run npm run lint and try to solve the lint errors after that we will merge your pr.

@Anurag519Narula
Copy link
Contributor Author

Hi @Anshgrover23 please merge.

@Anshgrover23 Anshgrover23 merged commit a646609 into Groverio:main Oct 12, 2024
2 checks passed
@Anshgrover23
Copy link
Collaborator

@Anurag519Narula thanks for contributing, kindly give us a star on this repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
hacktoberfest hacktoberfest-accepted
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] Time and date doesnt come when you have updated your list item
2 participants
@Anurag519Narula @Anshgrover23