Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CellPositionsHCalBarrelPhiThetaSegTool vs CellPositionsHCalPhiThetaSegTool #112

Closed
giovannimarchiori opened this issue Sep 4, 2024 · 1 comment · Fixed by #127
Closed

CellPositionsHCalBarrelPhiThetaSegTool vs CellPositionsHCalPhiThetaSegTool #112

giovannimarchiori opened this issue Sep 4, 2024 · 1 comment · Fixed by #127

Comments

@giovannimarchiori
Copy link
Contributor

Do we still need CellPositionsHCalBarrelPhiThetaSegTool? It seems to be to be completely superseded by CellPositionsHCalPhiThetaSegTool and thus could be removed

Tagging @mmlynari
@mmlynari
Copy link
Contributor

mmlynari commented Sep 6, 2024 •
edited
Loading

Hi @giovannimarchiori , indeed, we can remove CellPositionsHCalBarrelPhiThetaSegTool

@giovannimarchiori giovannimarchiori mentioned this issue Nov 6, 2024
Merged
@giovannimarchiori giovannimarchiori linked a pull request Nov 7, 2024 that will close this issue
remove CellPositionsHCalBarrelPhiThetaSegTool #127
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

remove CellPositionsHCalBarrelPhiThetaSegTool giovannimarchiori/k4RecCalorimeter
2 participants
@giovannimarchiori @mmlynari