e2e fixes

Author: doug-s-nava

frontend/package-lock.json

@@ -21,7 +21,7 @@ test.describe("Search error page", () => {
 
     await toggleCheckbox(page, "status-closed");
 
-    await page.waitForURL(/status=forecasted,posted,closed/, {
+    await page.waitForURL(/closed/, {
       timeout: 5000,
     });
   });

frontend/tests/e2e/search/search-error.spec.ts

@@ -1,4 +1,4 @@
-import skip, { expect, test } from "@playwright/test";
+import { expect, test } from "@playwright/test";
 import { chromium } from "playwright-core";
 import {
   fillSearchInputAndSubmit,
@@ -7,7 +7,7 @@ import {
 
 test.describe("Search page loading state", () => {
   // Loadiing indicator resolves too quickly to reliably test in e2e.
-  skip("should show and hide loading state", async () => {
+  test.skip("should show and hide loading state", async () => {
     const searchTerm = generateRandomString([4, 5]);
     const searchTerm2 = generateRandomString([8]);
 

frontend/tests/e2e/search/search-loading.spec.ts

@@ -360,13 +360,13 @@ test.describe("Search page tests", () => {
 
       await waitForAnyURLChange(page, urlBeforeInteraction);
 
-      // validate that new search results are returned with filtered (smaller number) of results
       const topLevelAndNestedSelectedNumberOfSearchResults =
         await getNumberOfOpportunitySearchResults(page);
 
+      // we've selected more agencies, so there should be more results
       expect(
         topLevelAndNestedSelectedNumberOfSearchResults,
-      ).toBeLessThanOrEqual(topLevelSelectedNumberOfSearchResults);
+      ).toBeGreaterThanOrEqual(topLevelSelectedNumberOfSearchResults);
 
       // validate that nested checkboxes are checked
       let checkboxes = await page.locator(nestedFilterCheckboxesSelector).all();