Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev deploys with netlify #1481

Open
klieret opened this issue Jan 5, 2024 · 2 comments
Open

Dev deploys with netlify #1481

klieret opened this issue Jan 5, 2024 · 2 comments

Comments

@klieret
Copy link
Member

klieret commented Jan 5, 2024

Using a setup with http://netlify.com/, we could get build previews for all PRs. This is basically zero configuration and free. The only limitation is that only one user can be an admin for a free netlify project and there are some rate limitation. But we could still have the main build be run by github pages, so that this would be just an addon.

@klieret
Copy link
Member Author

klieret commented Jan 5, 2024

This is what we're doing with https://github.com/hsf-training/training-center (if you check any PR, you can see links to previews).

What do you think @hegner @graeme-a-stewart

@graeme-a-stewart
Copy link
Member

Hi @klieret - apologies for the tardy response! Yes, it does seem like a good idea. Setting up Jekyll locally is quite fiddly (brew upgraded my Ruby to 3.3 recently and this seems not to work with GitHub Pages, so now I have to fiddle in a Ruby 3.2 version to work with the website). It would also help reviewers, who would not have to build a PR to check it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants