Skip to content

Commit 18bbe02

Browse files
committed
Fix maxTransfers
1 parent 087c436 commit 18bbe02

File tree

2 files changed

+10
-2
lines changed

2 files changed

+10
-2
lines changed

src/main/java/org/opentripplanner/apis/gtfs/mapping/routerequest/TransitPreferencesMapper.java

+9-1
Original file line numberDiff line numberDiff line change
@@ -75,10 +75,18 @@ static void setTransitPreferences(
7575
}
7676
var maxTransfers = transfer.getGraphQLMaximumTransfers();
7777
if (maxTransfers != null) {
78-
transferPreferences.withMaxTransfers(maxTransfers);
78+
if (maxTransfers < 0) {
79+
throw new IllegalArgumentException("Maximum transfers must be non-negative.");
80+
}
81+
transferPreferences.withMaxTransfers(maxTransfers + 1);
7982
}
8083
var additionalTransfers = transfer.getGraphQLMaximumAdditionalTransfers();
8184
if (additionalTransfers != null) {
85+
if (additionalTransfers < 0) {
86+
throw new IllegalArgumentException(
87+
"Maximum additional transfers must be non-negative."
88+
);
89+
}
8290
transferPreferences.withMaxAdditionalTransfers(additionalTransfers);
8391
}
8492
}

src/test/java/org/opentripplanner/apis/gtfs/mapping/routerequest/RouteRequestMapperTransitTest.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -89,7 +89,7 @@ void testTransferPreferences() {
8989
assertEquals(cost.toSeconds(), transferPreferences.cost());
9090
assertEquals(slack.toSeconds(), transferPreferences.slack());
9191
assertEquals(maximumAdditionalTransfers, transferPreferences.maxAdditionalTransfers());
92-
assertEquals(maximumTransfers, transferPreferences.maxTransfers());
92+
assertEquals(maximumTransfers + 1, transferPreferences.maxTransfers());
9393
}
9494

9595
@Test

0 commit comments

Comments
 (0)