Discourage walking when sidepaths are available

Author: optionsome

src/main/java/org/opentripplanner/openstreetmap/tagmapping/FinlandMapper.java

@@ -1,5 +1,6 @@
 package org.opentripplanner.openstreetmap.tagmapping;
 
+import static org.opentripplanner.openstreetmap.wayproperty.MixinPropertiesBuilder.ofWalkSafety;
 import static org.opentripplanner.openstreetmap.wayproperty.WayPropertiesBuilder.withModes;
 import static org.opentripplanner.street.model.StreetTraversalPermission.ALL;
 import static org.opentripplanner.street.model.StreetTraversalPermission.CAR;
@@ -163,6 +164,12 @@ else if (speedLimit <= 16.65f) {
     props.setProperties("highway=service;tunnel=yes;access=destination", withModes(NONE));
     props.setProperties("highway=service;access=destination", withModes(ALL).bicycleSafety(1.1));
 
+    // Typically if this tag is used on a way, there is also a better option for walking.
+    // We don't need to set bicycle safety as cycling is not currently allowed on these ways.
+    props.setMixinProperties("bicycle=use_sidepath", ofWalkSafety(5));
+
+    props.setMixinProperties("foot=use_sidepath", ofWalkSafety(8));
+
     // Automobile speeds in Finland.
     // General speed limit is 80kph unless signs says otherwise.
     props.defaultCarSpeed = 22.22f;

src/test/java/org/opentripplanner/openstreetmap/tagmapping/FinlandMapperTest.java

@@ -162,6 +162,21 @@ public void testSafetyWithMixins() {
       wps.getDataForWay(wayWithMixinsAndCustomSafety).walkSafety().forward(),
       epsilon
     );
+
+    OSMWithTags wayWithBicycleSidePath = new OSMWithTags();
+    wayWithBicycleSidePath.addTag("bicycle", "use_sidepath");
+    assertEquals(
+      8,
+      wps.getDataForWay(wayWithBicycleSidePath).walkSafety().forward(),
+      epsilon
+    );
+    OSMWithTags wayWithFootSidePath = new OSMWithTags();
+    wayWithFootSidePath.addTag("foot", "use_sidepath");
+    assertEquals(
+      12.8,
+      wps.getDataForWay(wayWithFootSidePath).walkSafety().forward(),
+      epsilon
+    );
   }
 
   @Test