Skip to content

Commit 6aa9f79

Browse files
committed
chore: don't run fairly heavy topic assembly at every render
1 parent 1c702b9 commit 6aa9f79

File tree

1 file changed

+7
-6
lines changed

1 file changed

+7
-6
lines changed

app/component/itinerary/navigator/NaviCardContainer.js

Lines changed: 7 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -86,13 +86,14 @@ function NaviCardContainer(
8686
};
8787

8888
// track only relevant vehicles for the journey.
89-
const topics = getTopics(
90-
legs.filter(leg => legTime(leg.end) >= time),
91-
config,
92-
);
89+
const getNaviTopics = () =>
90+
getTopics(
91+
legs.filter(leg => legTime(leg.end) >= time),
92+
config,
93+
);
9394

9495
useEffect(() => {
95-
updateClient(topics, context);
96+
updateClient(getNaviTopics(), context);
9697
}, []);
9798

9899
useEffect(() => {
@@ -129,7 +130,7 @@ function NaviCardContainer(
129130
}
130131
let timeoutId;
131132
if (legChanged) {
132-
updateClient(topics, context);
133+
updateClient(getNaviTopics(), context);
133134
setCardExpanded(false);
134135
setLegChanging(true);
135136
timeoutId = setTimeout(() => {

0 commit comments

Comments
 (0)