Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Angular 17 #190

Open
MurhafSousli opened this issue Feb 5, 2024 · 3 comments
Open

Upgrade to Angular 17 #190

MurhafSousli opened this issue Feb 5, 2024 · 3 comments

Comments

@MurhafSousli
Copy link

Installing the package causes peerDependency error

Current workaround is to add the following in the package.json file:

"overrides": {
    "mat-table-filter": {
      "@angular/cdk": ">=14.2.7",
      "@angular/material": ">=14.2.7",
      "@angular/common": ">=14.2.0",
      "@angular/core": ">=14.2.0"
    }
}
@GaneshKumarTrimble
Copy link

GaneshKumarTrimble commented Apr 26, 2024

I also would like to know if there is a plan to upgrade this to angular 17.

@spock123
Copy link

And now 18

@Will-at-FreedomDev
Copy link

Will-at-FreedomDev commented Jun 21, 2024

Installing the package causes peerDependency error

Current workaround is to add the following in the package.json file:

"overrides": {
    "mat-table-filter": {
      "@angular/cdk": ">=14.2.7",
      "@angular/material": ">=14.2.7",
      "@angular/common": ">=14.2.0",
      "@angular/core": ">=14.2.0"
    }
}

Cool, I didn't know that this works as a workaround to the peer dependency error (other than ignoring all peer dependencies). TBH this is a fine solution if there is no broken behavior.

I sent the author an email once in the past a while back about keeping up to date, and I got the impression that I don't think this author is planning on keeping up to date with Angular versions.

We plan on continuing to use this package until an Angular Material breaking change causes an issue some version in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants