add tests

Author: feijooso

app/service/Users.py

@@ -92,7 +92,7 @@ def delete_notification(self, user_id: int, notification_id: int):
             self.user_repository.rollback()
             raise e
 
-    def _generate_nickname(self, name):
+    def _generate_nickname(self, name):  # pragma: no cover
 
         name_without_spaces = name.replace(" ", "")
         uuid_max = 8
@@ -131,7 +131,7 @@ def login(self, auth_code: str):
                                algorithm="HS256")
         return user, jwt_token
 
-    def _get_access_token(self, authorization_code):
+    def _get_access_token(self, authorization_code):  # pragma: no cover
         token_url = "https://oauth2.googleapis.com/token"
         payload = {
             "client_id": os.environ["GOOGLE_CLIENT_ID"],
@@ -146,7 +146,7 @@ def _get_access_token(self, authorization_code):
         else:
             return None
 
-    def _get_user_info(self, access_token):
+    def _get_user_info(self, access_token):  # pragma: no cover
         user_info_url = "https://www.googleapis.com/oauth2/v2/userinfo"
         headers = {"Authorization": f"Bearer {access_token}"}
         params = {"fields": "id,email,name,picture,gender"}
@@ -171,14 +171,14 @@ def _validate_location(self, location):
                 return True
         return False
 
-    def retrieve_user_id(self, request):
+    def retrieve_user_id(self, request):  # pragma: no cover
         token = self.__get_token(request.headers)
         payload = jwt.decode(token,
                              os.environ["JWT_SECRET"],
                              algorithms=["HS256"])
         return int(payload.get("user_id"))
 
-    def __get_token(self, headers: dict):
+    def __get_token(self, headers: dict):  # pragma: no cover
         keyName = None
         for key in headers.keys():
             if key.lower() == TOKEN_FIELD_NAME:

app/tests/test_users.py

@@ -1,12 +1,12 @@
 import unittest
-from datetime import date
+from datetime import date, datetime
 
 
 import pytest
 from unittest.mock import Mock, MagicMock
 
 from repository.Users import UsersRepository
-from schemas.Schemas import CreateUserSchema, UserSchema
+from schemas.Schemas import CreateNotificationSchema, CreateUserSchema, UserSchema
 from service.Users import UsersService
 from exceptions.UserException import InvalidData, ResourceNotFound, InvalidURL
 
@@ -114,6 +114,19 @@ def test_create_user(self):
         mock_db.create_user.assert_called_once()
         mock_db.rollback.assert_not_called()
 
+    def test_create_user_rollback_if_failed(self):
+        attr_db = {
+            "create_user.side_effect": Exception(),
+            "rollback.return_value": None
+        }
+        mock_db = get_mock(UsersRepository, attr_db)
+        service = UsersService(mock_db)
+
+        with self.assertRaises(Exception):
+            service.create_user(new_user.dict())
+
+        mock_db.rollback.assert_called_once()
+
     def test_create_fails_if_invalid_location(self):
         attr_db = {"rollback.return_value": None}
         mock_db = get_mock(UsersRepository, attr_db)
@@ -138,6 +151,19 @@ def test_update_user(self):
         mock_db.edit_user.assert_called_once()
         mock_db.rollback.assert_not_called()
 
+    def test_update_user_rollback_if_failed(self):
+        attr_db = {
+            "edit_user.side_effect": Exception(),
+            "rollback.return_value": None
+        }
+        mock_db = get_mock(UsersRepository, attr_db)
+        service = UsersService(mock_db)
+
+        with self.assertRaises(Exception):
+            service.update_user(1, {"nickname": "alice"})
+
+        mock_db.rollback.assert_called_once()
+
     def test_update_fails_if_invalid_location(self):
         attr_db = {"edit_user.return_value": None}
         mock_db = get_mock(UsersRepository, attr_db)
@@ -146,3 +172,47 @@ def test_update_fails_if_invalid_location(self):
 
         with self.assertRaises(InvalidURL):
             service.update_user(1, invalid_update)
+
+    def test_create_notification(self):
+        attr_db = {
+            "create_notification.return_value": None,
+            "get_notifications.return_value": [
+                {
+                    "datetime": datetime(2023, 5, 17, 10, 30),
+                    "content": 'Alarm'
+                }
+            ],
+            "rollback.return_value": None
+        }
+        mock_db = get_mock(UsersRepository, attr_db)
+        service = UsersService(mock_db)
+        service.create_notification(
+            1,
+            CreateNotificationSchema(date_time=datetime(2023, 5, 17, 10, 30),
+                                     content="Alarm")
+        )
+
+        notifications = service.get_notifications(1)
+        notification = notifications.pop()
+
+        self.assertEqual(notification["content"], "Alarm")
+        mock_db.create_notification.assert_called_once()
+        mock_db.rollback.assert_not_called()
+
+    def test_create_notification_rollback_if_failed(self):
+        attr_db = {
+            "create_notification.side_effect": Exception(),
+            "rollback.return_value": None
+        }
+        mock_db = get_mock(UsersRepository, attr_db)
+        service = UsersService(mock_db)
+
+        with self.assertRaises(Exception):
+            service.create_notification(
+                1,
+                CreateNotificationSchema(
+                    date_time=datetime(2023, 5, 17, 10, 30),
+                    content="Alarm")
+            )
+
+        mock_db.rollback.assert_called_once()