update database object classes

Author: Hanashi

files/lib/data/discord/bot/DiscordBot.class.php

@@ -3,6 +3,7 @@
 namespace wcf\data\discord\bot;
 
 use wcf\data\DatabaseObject;
+use wcf\data\file\File;
 use wcf\system\cache\builder\DiscordGuildChannelCacheBuilder;
 use wcf\system\discord\DiscordApi;
 
@@ -25,6 +26,7 @@
  * @property-read string|null $clientSecret
  * @property-read string|null $publicKey
  * @property-read int $botTime
+ * @property-read int|null $webhookIconID
  */
 final class DiscordBot extends DatabaseObject
 {
@@ -53,9 +55,9 @@ public function getWebhookIconUploadFileLocations(): array
     {
         $files = [];
 
-        $filename = \sprintf('%simages/discord_webhook/%s.png', WCF_DIR, $this->botID);
-        if (\file_exists($filename)) {
-            $files[] = $filename;
+        if ($this->webhookIconID !== null) {
+            $file = new File($this->webhookIconID);
+            $files[] = $file->getPath();
         }
 
         return $files;

files/lib/data/discord/bot/DiscordBotAction.class.php

@@ -7,7 +7,6 @@
 use wcf\system\cache\builder\DiscordGuildChannelsCacheBuilder;
 use wcf\system\exception\AJAXException;
 use wcf\system\exception\PermissionDeniedException;
-use wcf\system\file\upload\UploadFile;
 use wcf\system\WCF;
 
 /**
@@ -47,13 +46,7 @@ public function create()
             unset($this->parameters['data']['useApplicationCommands']);
         }
 
-        $discordBot = parent::create();
-
-        if (isset($this->parameters['webhookIcon']) && \is_array($this->parameters['webhookIcon'])) {
-            $this->processWebhookIcon($discordBot->botID);
-        }
-
-        return $discordBot;
+        return parent::create();
     }
 
     #[Override]
@@ -67,34 +60,6 @@ public function update()
         }
 
         parent::update();
-
-        foreach ($this->getObjects() as $object) {
-            if (isset($this->parameters['webhookIcon']) && \is_array($this->parameters['webhookIcon'])) {
-                if ($this->parameters['webhookIcon'] === '') {
-                    $filename = \sprintf('%simages/discord_webhook/%s.png', WCF_DIR, $object->botID);
-                    if (\file_exists($filename)) {
-                        \unlink($filename);
-                    }
-                } else {
-                    $this->processWebhookIcon($object->botID);
-                }
-            }
-        }
-    }
-
-    #[Override]
-    public function delete()
-    {
-        $returnValues = parent::delete();
-
-        foreach ($this->getObjects() as $object) {
-            $filename = \sprintf('%simages/discord_webhook/%s.png', WCF_DIR, $object->botID);
-            if (\file_exists($filename)) {
-                \unlink($filename);
-            }
-        }
-
-        return $returnValues;
     }
 
     #[Override]
@@ -103,23 +68,6 @@ protected function resetCache()
         DiscordGuildChannelsCacheBuilder::getInstance()->reset();
     }
 
-    /**
-     * verarbeitet hochgeladenes Icon
-     *
-     * @param  mixed $botID
-     * @return void
-     */
-    protected function processWebhookIcon(int $botID)
-    {
-        $iconFile = \reset($this->parameters['webhookIcon']);
-        if ($iconFile instanceof UploadFile && !$iconFile->isProcessed()) {
-            $filename = \sprintf('%simages/discord_webhook/%s.png', WCF_DIR, $botID);
-
-            \rename($iconFile->getLocation(), $filename);
-            $iconFile->setProcessed($filename);
-        }
-    }
-
     /**
      * validiert die Methode getBotToken
      *