Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tab autocompletion is buggy when text is present at caret #3338

Closed
jojo2357 opened this issue Dec 3, 2023 · 6 comments
Closed

Tab autocompletion is buggy when text is present at caret #3338

jojo2357 opened this issue Dec 3, 2023 · 6 comments
Labels
bug Deficiencies in TeXiFy behaviour. external Issue is submitted elsewhere as it is (most likely) not a TeXiFy issue

Comments

@jojo2357
Copy link
Contributor

jojo2357 commented Dec 3, 2023

Half a bug, half a missing feature.

\begin{document}
$5\lamb<caret>$
\end{document}

select the completion \lambda with tab and the closing $ will be consumed

Expected:

\begin{document}
$5\lambda$
\end{document}

Actual:

\begin{document}
$5\lambda
\end{document}
@jojo2357 jojo2357 added enhancement New feature or (non bug related) change to the program. untriaged Issue type still needs to be triaged or verified. labels Dec 3, 2023
@PHPirates
Copy link
Collaborator

Thanks, indeed something strange is going on, another example:

Given: \input{te<caret>.tex}
Expected after tab completion: \input{texbook.tex}
Actual: \itexbook.tex}

@PHPirates PHPirates changed the title Stop consuming $ when autocompleting command in math environment Tab autocompletion is buggy when text is present at caret Dec 4, 2023
@PHPirates PHPirates added bug Deficiencies in TeXiFy behaviour. and removed enhancement New feature or (non bug related) change to the program. untriaged Issue type still needs to be triaged or verified. labels Dec 4, 2023
slideclimb added a commit that referenced this issue Dec 29, 2023
@slideclimb
Copy link
Collaborator

@PHPirates PHPirates added the external Issue is submitted elsewhere as it is (most likely) not a TeXiFy issue label Dec 30, 2023
@slideclimb
Copy link
Collaborator

Thanks, indeed something strange is going on, another example:

Given: \input{te<caret>.tex} Expected after tab completion: \input{texbook.tex} Actual: \itexbook.tex}

This bug already exists as TEX-153, I suggests keeping it separate from this as it's a different issue - I have been debugging, fix should be coming soon :)

@frankbits
Copy link
Contributor

frankbits commented Apr 30, 2024

This bug already exists as TEX-153, I suggests keeping it separate from this as it's a different issue - I have been debugging, fix should be coming soon :)

Could you add a link to the issue? I have a similar problem with \addbibresource{} (as well as the mentioned one with \input{}).
Where is / was this tracked?

@frankbits
Copy link
Contributor

frankbits commented Apr 30, 2024

oh, the github-actions-bot added the link to my comment (still In Progress?).
And from there I found the pull-request on github (merged in v0.9.4).
That way I found out that I was using an old version of TeXiFy, as PHPStorm on this device was not up-to-date.
After updating my IDE, I could update TeXiFy, which fixed the problem for me.

@PHPirates
Copy link
Collaborator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Deficiencies in TeXiFy behaviour. external Issue is submitted elsewhere as it is (most likely) not a TeXiFy issue
Projects
None yet
Development

No branches or pull requests

4 participants