Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Weblinks enclosed in quotation marks try to open as file #3472

Closed
frankbits opened this issue Feb 29, 2024 · 0 comments · Fixed by #3499
Closed

Weblinks enclosed in quotation marks try to open as file #3472

frankbits opened this issue Feb 29, 2024 · 0 comments · Fixed by #3499
Assignees
Labels
bug Deficiencies in TeXiFy behaviour.
Milestone

Comments

@frankbits
Copy link
Contributor

Type of JetBrains IDE (IntelliJ, PyCharm, etc.) and version

PhpStorm 2023.2.4

Operating System

Windows 10

TeXiFy IDEA version

0.9.2

What I did (steps to reproduce)

I have multiple _.bib-files, generated by online libraries.
Some of those generate their fields, including the url-field, enclosed in "_" and not in {_}.
Now I wanted to Ctrl-click on those links, to follow them to the source to reread something.

Minimal example to reproduce the problem

does work:

@online{TeXiFy-IDEA,
    url={https://github.com/Hannah-Sten/TeXiFy-IDEA}
}

does not work:

@online{TeXiFy-IDEA,
    url="https://github.com/Hannah-Sten/TeXiFy-IDEA"
}

Expected behavior

"Link" opens normally, as {Link} does.

Actual behavior

The quotation marks (") are included in the URL to be opened, and so it does not recognize it as a Weblink, but tries to open a file in the PHPStorm-directory:

"file:///C:\Users\<User>\AppData\Local\Programs\PhpStorm\jbr\bin\\\https:\github.com\Hannah-Sten\TeXiFy-IDEA\"

The same happens for example with links in \href-commands, if they are enclosed in quotation marks (").
But there it is not as big of a problem, as \href{"link"}{label} is incorrect in LaTeX for \href{link}{label}.

Operating System Error:
image

PHPStorm Error: (only appears after the OS Error, if you close the OS Error relatively quickly)
image

@frankbits frankbits added bug Deficiencies in TeXiFy behaviour. untriaged Issue type still needs to be triaged or verified. labels Feb 29, 2024
@PHPirates PHPirates removed the untriaged Issue type still needs to be triaged or verified. label Mar 1, 2024
slideclimb added a commit that referenced this issue Mar 23, 2024
@slideclimb slideclimb self-assigned this Mar 24, 2024
@PHPirates PHPirates added this to the Next milestone Mar 30, 2024
PHPirates added a commit that referenced this issue Mar 30, 2024
Fix #3472 by finishing implementation of urls in bib as verbatim
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Deficiencies in TeXiFy behaviour.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants