From 9a13d824c0a04a34d4e1acd1d0cd3effce9c15b3 Mon Sep 17 00:00:00 2001
From: "JET.D" <70251380+3LL4N@users.noreply.github.com>
Date: Fri, 8 Dec 2023 16:28:46 +0800
Subject: [PATCH] fix: stored algolia user data (#245)

* fix: added "atleast 1 corect answer" in multiple choices questions prompt

* fix: correct answers in multiple choice prompt

* fix: changed userd used to store and use in algolia index
---
 apps/nextjs/src/pages/api/algoliaUserHandler.ts               | 3 ++-
 packages/api/src/functions/randomQuestionsHandlers.ts         | 4 ++--
 .../services/algoliaApiHandlers/algoliaApiAddAllHandlers.ts   | 4 ++--
 .../api/src/services/algoliaApiHandlers/algoliaCudHandlers.ts | 3 ++-
 4 files changed, 8 insertions(+), 6 deletions(-)

diff --git a/apps/nextjs/src/pages/api/algoliaUserHandler.ts b/apps/nextjs/src/pages/api/algoliaUserHandler.ts
index 467a0bad..d89ca37a 100644
--- a/apps/nextjs/src/pages/api/algoliaUserHandler.ts
+++ b/apps/nextjs/src/pages/api/algoliaUserHandler.ts
@@ -27,10 +27,11 @@ export const updateUserInAlgolia = async (userData: UsersForAlgolia) => {
 
   const algoliaObject: Partial<UsersForAlgolia> & { objectID: string } = {
     ...userData,
-    objectID: userData.id,
+    objectID: userData.userId,
   };
 
   delete algoliaObject.id;
+  delete algoliaObject.userId;
 
   const index = client.initIndex("users");
 
diff --git a/packages/api/src/functions/randomQuestionsHandlers.ts b/packages/api/src/functions/randomQuestionsHandlers.ts
index 89068f35..f1f61544 100644
--- a/packages/api/src/functions/randomQuestionsHandlers.ts
+++ b/packages/api/src/functions/randomQuestionsHandlers.ts
@@ -48,7 +48,7 @@ export const questionFormatGenerators: {
   ) => `separator\nQuestion: [Your question here, max ${maxCharsForQuestion} characters]
   ${generateChoicesPrompt(
     numChoices,
-  )}\nCorrect Answer: Option [Correct option number] ${timeAndPointsPrompt}`,
+  )}\nCorrect Answer: Option [Correct option number and only 1 correct answer] ${timeAndPointsPrompt}`,
 
   multiselect: (
     numChoices = 4,
@@ -56,7 +56,7 @@ export const questionFormatGenerators: {
   ) => `separator\nQuestion: [Your question here, max ${maxCharsForQuestion} characters]
   ${generateChoicesPrompt(
     numChoices,
-  )}\nAll Correct Answers: Options [Correct option numbers separated by commas, e.g., 1,3] ${timeAndPointsPrompt}`,
+  )}\nAll Correct Answers: Options [Correct option numbers separated by commas (e.g., 1,3) and at least one correct answer] ${timeAndPointsPrompt}`,
 
   identification: (maxCharsForQuestion = 100, maxCharsForChoice = 68) =>
     `separator\nQuestion: [Your question here, max ${maxCharsForQuestion} characters]\nAnswer: [Your answer here, max ${maxCharsForChoice} characters] ${timeAndPointsPrompt}`,
diff --git a/packages/api/src/services/algoliaApiHandlers/algoliaApiAddAllHandlers.ts b/packages/api/src/services/algoliaApiHandlers/algoliaApiAddAllHandlers.ts
index 916c0944..91658b12 100644
--- a/packages/api/src/services/algoliaApiHandlers/algoliaApiAddAllHandlers.ts
+++ b/packages/api/src/services/algoliaApiHandlers/algoliaApiAddAllHandlers.ts
@@ -47,8 +47,8 @@ export const addAllTestsToAlgolia = async (
 };
 
 const parseUsersToAlgolia = async (data: Promise<UsersForAlgolia[]>) => {
-  const usersAlgoliaRecords = (await data).map(({ id, ...rest }) => ({
-    objectID: id,
+  const usersAlgoliaRecords = (await data).map(({ userId, ...rest }) => ({
+    objectID: userId,
     ...rest,
   }));
 
diff --git a/packages/api/src/services/algoliaApiHandlers/algoliaCudHandlers.ts b/packages/api/src/services/algoliaApiHandlers/algoliaCudHandlers.ts
index 091b6ee1..9b0e9016 100644
--- a/packages/api/src/services/algoliaApiHandlers/algoliaCudHandlers.ts
+++ b/packages/api/src/services/algoliaApiHandlers/algoliaCudHandlers.ts
@@ -76,10 +76,11 @@ export const deleteReviewerFromAlgolia = async (reviewerId: string) => {
 export const updateUserInAlgolia = async (userData: UsersForAlgolia) => {
   const algoliaObject: Partial<UsersForAlgolia> & { objectID: string } = {
     ...userData,
-    objectID: userData.id,
+    objectID: userData.userId,
   };
 
   delete algoliaObject.id;
+  delete algoliaObject.userId;
 
   const client = initializeAlgoliaClient();
   const index = client.initIndex("users");