-
-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CSS font-family and font-size #170
Comments
At the moment, this behaviour is by design.
As for the line breaks, I think it's a great idea to add them (and hopefully not too difficult to implement, either). This could also allow me to increase the font size on the approximate timer. Since I'm going to rework the timers, anyway, I'll probably implement some design changes, too. I'm also thinking of designing an Android 12-like clock display, which would also require numbers to be of the same width, but that can probably be solved with a grid. |
@Hanziness Yes, I'm aware of the typographic problems. Therefore I've produced the "PoppinsAP" fonts (regular and bold) for you. They are identical with the original "Poppins", but I've added "real" tabular figures (tnum) and a special (raised) colon glyph (ss05). If you like, you could experiment with the fonts and see if they fit your needs. You could then use the property For the .timer classes you could then use something like this:
For the
IMO, for the large text you don't need 14 rem. I think 10rem is big enough.
Also, if you decide not to use Day.js (#163), then for the I hope some of my ideas will help. If you don't like any of it, that's ok too. |
Thank you very much for the feedback and the font, @milotype! I'm not sure about the licensing nitty-gritty with the modified Poppins (but I will check it out, thank you for providing this!), and since the problem of not having tabular figures is only relevant with the precise timer, I think I'll try to display the timer using a grid first (each number and the colon get a fixed width column, so the text won't "jump" when the timer changes). I'll also check the font sizes while I'm at it. Development has slowed because I've got a bit busier, but all these changes will be implemented soon, hopefully :) |
@Hanziness To my knowledge the licensing shouldn't be a problem. The font with tabular figures as font feature I made, have the same OFL license as the original ones. Also there is no "Reserved Font Name" for Poppins, so renaming your versions to "PoppinsAP" should be legitimate. |
I've managed to solve the issue of non-tabular figures using CSS*, so the regular Poppins font can still be used (and retrieved from Google Fonts, reducing the required bandwidth). I also updated the designs. *: For other developers: I created |
@Hanziness It's your app, so obviously, it's your decision … but as a typographer, I definitely disapprove your changes! From a typographical point of view, it's simply incorrect and looks strange. Time should be displayed (at least) in the format Why did you decide against my generated fonts including my proposed CSS? I'm not a programmer, so I cannot prove it: but, IMO, calling fonts from Google Fonts or from your own domain shouldn't make a difference (or at least shouldn't have such a great impact). I agree about removing the dependency on day.js … in that case don't forget to include/add translatable strings, as mentioned in my previous comment. |
@milotype thank you very much for your detailed feedback, I truly appreciate it! Let's tackle both things: Timer layout / designYou might very well be right and I'll reopen this issue to further work on the timers. My concept with the redesign was shifting the emphasis onto the minutes. The previous "minutes:seconds" layout (both numbers using the same font weight and size) didn't do that and in my opinion a timer app should not communicate the frequently changing seconds counter that strongly because it might divert the user's attention. If I give less weight to the seconds, the attention shifts (or should shift) to the minute counter, but if needed, the second counter is still visible at a glance. What are your thoughts? Do you think this is doable somehow if the current design does it badly? My current plan now is to roll back to the previous colon-separated display ( On the second screenshot (mobile view) the timer design is based on the Android 12 lock screen clock (which is displayed when there are no notifications to be shown; see below picture) where the numbers seem to be laid out on a 2-by-2 grid and they vertically align, too, seemingly at the centre. To my eyes, letter spacing with Poppins currently does not look bad (though I imagine it would be better if the font had tabular figures - more on this later). Why not include the modified PoppinsThe reason is bandwidth and it can be split into two more reasons.
This, in my eyes, makes the use of the modified font quite problematic and I wanted to avoid these issues as much as I could - hence the attempt of trying to use a grid to lay out the timer. TranslationsThe new files do have the required translations - I settled with not showing "a few seconds" but only "1 minute" in the end. They will be in the Crowdin project :) |
@Hanziness IMO, the "minutes:seconds" layout should not have different font styles for minutes and seconds. I aggree to keep the dislay of time with the colon (ideally with a raised colon). As a matter of fact, all displayed styles (traditional, approximate and percentage) should simply use the bold version of the font. (BTW, you are talking about traditional timer setting with second-precision on the GitHub's README file.). Deemphasizing "seconds" by using a different font style makes no sense to me and I do not see any danger of diverting the user's attention. I do understand your concern about bandwidth though … BTW, Android's display of times is not the non-plus-ultra! So following Android's display isn't necessarily the way to go (IMO). |
To keep in line with the "traditional" name, you might be right to just keep everything the same, then I could implement a fancier "clock" timer so if someone needs a different looking timer, they can use that, too. Making everything boldI don't agree with making everything just bold (if that's what you meant), though, at least in the approximate and percentage timers. In my opinion, the numbers should certainly be bold, but the units like "minute(s)", "hour(s)" and the percentage sign express secondary information, eg. in "25 minutes". It (for the remaining time) will remain "minutes", and that string is already quite long compared to the displayed 2 digits, no need to further emphasise it as it takes more screen space than the actual useful piece of information ("how many minutes I have left"). The same goes for "42 %", it will always express percentage and it likely won't become confusing or strange-looking if I don't emphasise the percentage sign. Additional changes from #186An additional change that I implemented in #186 was to make these "secondary" texts smaller, but vertically centred. In my opinion, they look better this way, but now that I'm back at the drawing board, I'd ask for feedback on these, too. Do you think this looks okay? Another option I considered was to align the text at the baseline, but since the whole timer display is already centred, it made more sense to keep everything at the centre (otherwise it would look like the timer is below centre). Personal opinion on the clock displayWhile Android's time display might not be the best-in-class (though the question is in what terms is it not that great), I'd argue it looks fresh, is legible from far away and reacts very well to changing time (remaining in the same place regardless of the digits displayed). There's probably no design that satisfies all needs, but it seems to offer a great trade-off between bold and still legible design and "the way" of laying out time on paper, and I don't see any problems with following it (this is an app that is viewed on screen). Another reason would be (but you're probably well aware of it) that browsers are not that great at laying out text anyway, so I wouldn't try fighting them to get print-quality text in an app that features a rounded, bold display. So here, feedback is much appreciated: do these timers look acceptable or should they use the same font configuration as the numbers? |
IMO, everything should be bold and the same size. |
Describe the bug
CSS class="timer-traditional", class="timer-approximate" and class="timer-percentage" do not use the same
font-family
norfont-size
.timer-traditional uses:
font-family: "Source Sans Pro",monospace;
and 72pxtimer-percentage uses:
font-family: "Source Sans Pro",monospace;
and 96pxtimer-approximate uses:
font-family: Poppins,sans-serif;
and 30pxExpected behavior
In my opinion:
font-family
andfont-size
-font-family: "Source Sans Pro",sans-serif;
font-family
asmonospace
Screenshots

Platform:
The text was updated successfully, but these errors were encountered: