Skip to content

check if javascript dialog is open #245

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

check if javascript dialog is open #245

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1921e65
#212 add `dialog_present?/0` function
Sebisnow Sep 11, 2019
bb2713e
test the presence of a dialog on an alert
Sebisnow Sep 11, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions lib/hound/helpers/dialog.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,21 @@ defmodule Hound.Helpers.Dialog do

import Hound.RequestUtils

@doc """
Checks if a dialog, javascript alert(), confirm() or prompt(), exists

dialog_present?()
"""
@spec dialog_present?() :: Boolean.t
def dialog_present? do
try do
dialog_text()
true
rescue
RuntimeError -> false
end
end

@doc """
Gets text of a javascript alert(), confirm() or prompt().

Expand Down
6 changes: 6 additions & 0 deletions test/helpers/dialog_test.exs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,12 @@ defmodule DialogTest do

hound_session()

test "Dialog present" do
navigate_to "http://localhost:9090/page1.html"
execute_script("alert('hello')")
assert dialog_present?() == true
end

test "Get dialog text" do
navigate_to "http://localhost:9090/page1.html"
execute_script("alert('hello')")
Expand Down