-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Not tracking full list of players? #3
Comments
I'm not 100% sure but is it possible you're hitting the PUBG API limit? It's currently set to 10 Requests Per Minute and with 25 players I can see that happening. |
Oh could be? I thought you could query multiple players using one request though? I atleast used two different API's for NA / EU though. |
@Haza I contacted PUBG API support in regards to an increase in API rate limit and they provided some useful suggestions that I think would be more useful if I passed on to you:
|
Thanks for testing. That being said, when you launch the bot, if a user does not have a match, if should be displayed on the console (see prefly.py, the line "print('No match found for ' + player.name)") I could be possible you're facing an API limit. Right now, all the player list is taken, and a query is made to the API (so 20 users means 20 requests). Adding something (don't really know how/what right now) to be able to run the bot with more users is a must have. But no ETA for this on my side right now. |
This is the output based on a list of 25 users but seems to only go through 3 of them: NA Output:
EU Output:
|
Could you provide your users file so I can test it? Thanks |
Sure:
|
I tested with you user list. You can test yourself by using It return only 3 players. (I removed the matches).
This is really what the API is returning while searching for players. |
for NA I know I know these have all played within last 2 weeks (likely more of them but these I've seen play): Some played EU and NA aside from maybe Tommy-G I think all of them have played within the last 2 weeks |
Hey, firstly thanks for making this.
I am running two separate instances, one with PC_NA and one with PC_EU as discord is fairly evenly split between the two and people switch between them depending on who is playing.
I have added 25 players to the users.json in each instance - When I run the the main.py it only goes through about 5 of them and those are the only ones whos matches get tracked? it seems to ignore the rest of the list (using the !players command displays the full player list).
Am I doing something wrong?
Thanks
The text was updated successfully, but these errors were encountered: