From 0a322569465dadf331bd55a0be43f9dc9e59b0db Mon Sep 17 00:00:00 2001
From: Haru <haru@dotalux.com>
Date: Sat, 31 Aug 2024 23:49:41 +0200
Subject: [PATCH] Drop the CI builds that require Ubuntu 18.04, which has been
 EoL for several months

The nodejs v20 actions require at least Ubuntu 20.04 to run. Downgrading
to nodejs 16 and extending its agony for a few more months until they
become fully unsupported seems pointless to me.

Signed-off-by: Haru <haru@dotalux.com>
---
 .github/workflows/controller.yml |  4 --
 .github/workflows/gccold3.yml    | 84 --------------------------------
 2 files changed, 88 deletions(-)
 delete mode 100644 .github/workflows/gccold3.yml

diff --git a/.github/workflows/controller.yml b/.github/workflows/controller.yml
index 1eeebf5d317..2b5cc80f00d 100644
--- a/.github/workflows/controller.yml
+++ b/.github/workflows/controller.yml
@@ -35,10 +35,6 @@ jobs:
     needs: build
     if: ${{ !failure() && !cancelled() }}
     uses: ./.github/workflows/gccold2.yml
-  gccold3:
-    needs: build
-    if: ${{ !failure() && !cancelled() }}
-    uses: ./.github/workflows/gccold3.yml
   gccsnapshot_test:
     needs: build
     if: ${{ !failure() && !cancelled() }}
diff --git a/.github/workflows/gccold3.yml b/.github/workflows/gccold3.yml
deleted file mode 100644
index 2dbf32d70d9..00000000000
--- a/.github/workflows/gccold3.yml
+++ /dev/null
@@ -1,84 +0,0 @@
-name: gcc_old3
-
-on: workflow_call
-
-env:
-  MYSQL_DATABASE: 'ragnarok'
-  MYSQL_USER: 'ragnarok'
-  MYSQL_PASSWORD: 'ragnarok'
-  MYSQL_ALLOW_EMPTY_PASSWORD: 'yes'
-  DEBIAN_COMMON_PACKAGES: make zlib1g-dev libpcre3-dev git python3 libzstd-dev
-  SKIP_VALIDATE_INTERFACES: "skip"
-
-jobs:
-  build:
-    runs-on: ubuntu-latest
-    timeout-minutes: 30
-    strategy:
-      matrix:
-        CC: ["gcc-6", "gcc-5", "gcc-4.8"]
-        RENEWAL: [""]
-        CLIENT_TYPE: ["", "--enable-packetver-re", "--enable-packetver-zero"]
-        HTTPLIB: ["", "--with-http_parser=llhttp"]
-        SANITIZER: ["--disable-manager --enable-sanitize=full"]
-        PACKET_VERSION: ["--enable-packetver=20100105", "--enable-packetver=20171018"]
-        LTO: [""]
-        exclude:
-          - PACKET_VERSION: "--enable-packetver=20100105"
-            CLIENT_TYPE: "--enable-packetver-zero"
-
-    # github.head_ref will stop previous runs in the same PR (if in a PR)
-    # github.run_id is a fallback when outside a PR (e.g. every merge in master will run, and previous won't stop)
-    concurrency:
-      group: gccold3-${{ github.head_ref || github.run_id }}_${{ matrix.CC }}_${{ matrix.RENEWAL }}_${{ matrix.CLIENT_TYPE }}_${{ matrix.HTTPLIB }}_${{ matrix.SANITIZER }}_${{ matrix.PACKET_VERSION}}_${{ matrix.LTO }}
-      cancel-in-progress: true
-
-    container:
-      image: ubuntu:18.04
-    services:
-      mariadb:
-        image: mariadb:latest
-        ports:
-          - 33306:3306
-        env:
-          MYSQL_DATABASE: 'ragnarok'
-          MYSQL_USER: 'ragnarok'
-          MYSQL_PASSWORD: 'ragnarok'
-          MYSQL_ALLOW_EMPTY_PASSWORD: 'yes'
-        options: >-
-          --health-cmd="healthcheck.sh --connect --innodb_initialized"
-          --health-interval=5s
-          --health-timeout=2s
-          --health-retries=3
-    env:
-      INSTALL_PACKAGES: ${{ matrix.CC }} mariadb-client libmariadbclient-dev-compat
-      SQLHOST: mariadb
-      CC: ${{ matrix.CC }}
-      CONFIGURE_FLAGS: CC=${{ matrix.CC }} --enable-debug --enable-Werror --enable-buildbot ${{ matrix.RENEWAL }} ${{ matrix.HTTPLIB }} ${{ matrix.CLIENT_TYPE }} ${{ matrix.SANITIZER }} ${{ matrix.PACKET_VERSION }} --enable-epoll
-    steps:
-      - uses: actions/checkout@v4
-        with:
-          fetch-depth: 1
-
-      - name: info
-        run: |
-          uname -a
-
-      - name: install packages
-        run: |
-          ./tools/ci/retry.sh apt-get update
-          ./tools/ci/retry.sh apt-get install -y -qq $INSTALL_PACKAGES $DEBIAN_COMMON_PACKAGES
-
-      - name: init database
-        run: |
-          ./tools/ci/travis.sh importdb ragnarok ragnarok ragnarok $SQLHOST
-
-      - name: get plugins
-        run: |
-          ./tools/ci/travis.sh getplugins || true
-
-      - name: build
-        run: |
-          ./tools/ci/travis.sh build $CONFIGURE_FLAGS
-
-        # for run default config will show warnings