Skip to content

Commit 2ef226e

Browse files
committed
update CI to use classic spell list for older clients
old clients can't properly load the main autospell db for RE, using the herc-provided fallback makes them pass.
1 parent c8f99d5 commit 2ef226e

File tree

1 file changed

+5
-3
lines changed

1 file changed

+5
-3
lines changed

.github/workflows/clang15_test.yml

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,10 @@ jobs:
2121
HTTPLIB: ["", "--with-http_parser=llhttp"]
2222
SANITIZER: ["--disable-manager", "--disable-manager --enable-sanitize=full"]
2323
PACKET_VERSION: ["--enable-packetver=20221024", "--enable-packetver=20130724"]
24-
include: # Use "CLASSIC_AUTOSPELL_LIST" for 20130724 RE or we will get warnings due to the list being too small
24+
include:
25+
# Empty CLASSIC_AUTOSPELL_LIST for every other flow
26+
- CLASSIC_AUTOSPELL_LIST: ""
27+
# Use "-DCLASSIC_AUTOSPELL_LIST" for 20130724 RE or we will get warnings due to the list being too small
2528
- PACKET_VERSION: "--enable-packetver=20130724"
2629
RENEWAL: ""
2730
CLASSIC_AUTOSPELL_LIST: "-DCLASSIC_AUTOSPELL_LIST"
@@ -56,8 +59,7 @@ jobs:
5659
INSTALL_PACKAGES: ${{ matrix.CC }} mariadb-client libmariadbclient-dev-compat
5760
SQLHOST: mariadb
5861
CC: ${{ matrix.CC }}
59-
CPPFLAGS: ${{ (matrix.CLASSIC_AUTOSPELL_LIST != '' && matrix.CLASSIC_AUTOSPELL_LIST) || '' }}
60-
CONFIGURE_FLAGS: CC=${{ matrix.CC }} --enable-debug --enable-Werror --enable-buildbot ${{ matrix.RENEWAL }} ${{ matrix.HTTPLIB }} ${{ matrix.CLIENT_TYPE }} ${{ matrix.SANITIZER }} ${{ matrix.PACKET_VERSION }} CPPFLAGS="${{ env.CPPFLAGS }}"
62+
CONFIGURE_FLAGS: ${{ format('CC={0} --enable-debug --enable-Werror --enable-buildbot {1} {2} {3} {4} {5} CPPFLAGS={6}', matrix.CC, matrix.RENEWAL, matrix.HTTPLIB, matrix.CLIENT_TYPE, matrix.SANITIZER, matrix.PACKET_VERSION, matrix.CLASSIC_AUTOSPELL_LIST) }}
6163
PACKET_VERSION: ${{ matrix.PACKET_VERSION }}
6264
steps:
6365
- uses: actions/checkout@v1

0 commit comments

Comments
 (0)