Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Browser Compatibility #89

Open
spaceface777 opened this issue Mar 21, 2019 · 11 comments
Open

Browser Compatibility #89

spaceface777 opened this issue Mar 21, 2019 · 11 comments
Labels
1. Type: info Info about Hermes

Comments

@spaceface777
Copy link
Contributor

spaceface777 commented Mar 21, 2019

This issue is to give information on problems that come from using the different browsers, and their compatibility. This compatibility chart uses the latest version of each browser. PRs to improve browser compatibility are welcome, as long as that browser isn't one of the unsupported ones since we don't support these browsers.

Fully working

Google Chrome (and other browsers based on Chromium)

  • As this is the browser we have done most of the programming on, it is guaranteed to be 100% compatible with the app.

Mozilla Firefox

  • This browser should also be 100% compatible with the app, and we will try to ensure changes or new features also work on this browser.

Safari

  • Safari should also be entirely compatible with Hermes, but it may sometimes not work reliably on testing as not all of us have Macs to test on.

Partially working

Microsoft Edge

Once the new version of Edge (it's in the process of being ported to Chromium) is released, it will (hopefully) have the same compatibility as Chrome since they'll share rendering engines.

  • The basic Hermes features work on this browser (you can read and send messages), but there are some UI bugs / differences from the other browsers, and therefore using this browser is not recommended.

    • The website scrolls to the top every time you send a message
    • The right click menu doesn't work (it doesn't even appear, errors out in composedPath)
    • The textarea becomes two lines tall every time you send a message
    • The quote background doesn't appear
    • Web Push notifications don't work
    • The loading icon looks strange:
      icon

Not working at all (Unsupported)

Internet Explorer

  • As this is a very old browser, it does not support some of the JS functions (such as ES6) used in the app. Please use a different browser. We won't support IE
@spaceface777 spaceface777 added the 1. Type: info Info about Hermes label Mar 21, 2019
@spaceface777 spaceface777 pinned this issue Mar 21, 2019
@ThePerkinrex
Copy link
Contributor

Yeah, I will test it on safari

@ThePerkinrex
Copy link
Contributor

We should add Opera & test its compatibility

@spaceface777
Copy link
Contributor Author

We should add Opera & test its compatibility

Opera is based on Chromium, so I think the results will be similar to Chrome.

@ThePerkinrex
Copy link
Contributor

@spaceface777 I didn't know that

@ThePerkinrex
Copy link
Contributor

In safari, the page takes a lot to load, the loading icon dissapears, the order of the messages is wrong, and sw-register errors out:
Unhandled Promise Rejection: TypeError: undefined is not an object (evaluating 'reg.pushManager.getSubscription') (sw-register.js:23)

@ThePerkinrex
Copy link
Contributor

Then it gives a lot of errors about requests it's making (getSettings/...) (500)
So then JSON Parser crashes on line 321 of chat.js

@spaceface777
Copy link
Contributor Author

Since Safari compatibility has been fixed, it is now one of the fully working browsers.

@spaceface777
Copy link
Contributor Author

I also tested UC Browser, and it works mostly OK, apart from the strange Edge loading icon and the browser overriding the right click menu with their own.

@spaceface777
Copy link
Contributor Author

Most of the Edge issues have been fixed.

@spaceface777
Copy link
Contributor Author

Making Edge compatible isn't very important as the browser is in the process of being rebased on Chromium, and will therefore work exactly the same as Chrome.

@ThePerkinrex
Copy link
Contributor

Has Edge been ported to chromium on main branch yet?
Because if so, then Edge is fully supported

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1. Type: info Info about Hermes
Projects
None yet
Development

No branches or pull requests

2 participants