Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UX] Ignore Proton - Experimental by default, but allow enabling it for advanced usage #4254

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

arielj
Copy link
Collaborator

@arielj arielj commented Jan 10, 2025

This PR changes how we handle the Proton - Experimental option to run games.

We currently have a problem, that, for some users, Proton - Experimental might be the only wine/proton they have when they use Heroic for the first time and it gets assigned as a default game setting. From there, all their games ends up using Proton - Experimental with the risks that creates: it's experimental and not tested as much as stable versions, so an updated in steam without the user noticing it can break games in Heroic and it's hard to know what changed (users usually think nothing changed).

With this change, Proton - Experimental won't show up by default in the Wine Version selectors throughout the app, so inexperienced users can't select it by mistake and shouldn't be automatically selected by Heroic either (there's also this idea that, because it fixes many games, it's always better, so checking the option shows a warning for the user with some information about what experimental means).

For users that know what they are doing and want to be intentional about using Proton - Experimental, there's now a checkbox in Settings > Advances to stop ignoring it.


Use the following Checklist if you have changed something on the Backend or Frontend:

  • Tested the feature and it's working on a current and clean install.
  • Tested the main App features and they are still working on a current and clean install. (Login, Install, Play, Uninstall, Move games, etc.)
  • Created / Updated Tests (If necessary)
  • Created / Updated documentation (If necessary)

@arielj arielj added the pr:ready-for-review Feature-complete, ready for the grind! :P label Jan 10, 2025
@arielj arielj requested review from Etaash-mathamsetty, a team, flavioislima, CommandMC, Nocccer and imLinguin and removed request for a team January 10, 2025 00:02
@CommandMC
Copy link
Collaborator

Honestly I'd vote for ignoring all Proton versions found in that path by default (or at least everything non-GE-Proton). Regular Proton lacks Winetricks (and protonfixes as a whole), so you already lose a lot of games

@arielj
Copy link
Collaborator Author

arielj commented Jan 10, 2025

Honestly I'd vote for ignoring all Proton versions found in that path by default (or at least everything non-GE-Proton). Regular Proton lacks Winetricks (and protonfixes as a whole), so you already lose a lot of games

I'm not against that, personally I just use whatever I can get with heroic, I don't know what users expect but I don't see the point of using stock proton when ge-proton exists haha

We still have the Add custom Wine/Proton Paths for people that wants those I guess?

@Etaash-mathamsetty
Copy link
Member

Etaash-mathamsetty commented Jan 10, 2025

Honestly I'd vote for ignoring all Proton versions found in that path by default (or at least everything non-GE-Proton). Regular Proton lacks Winetricks (and protonfixes as a whole), so you already lose a lot of games

I save storage by installing stuff to the steam compatibilitytools.d folder, so +1 for ignoring everything that's not GE-proton by default (instead of removing that directory from the search path completely)

@arielj
Copy link
Collaborator Author

arielj commented Jan 10, 2025

Do you think the checkbox to enable those things is needed? I didn't want to remove things without having an option to have them back cause I imagine some users wanting that, but if there's no need for proton nor proton - experimental I wonder if we should just ignore them and that's it?

@arielj
Copy link
Collaborator Author

arielj commented Jan 10, 2025

The main thing I want to avoid with this PR is users using something unstable by default or by mistake, but let them use experimental if they need to (would experimental have fixes before ge-proton for example that users may want to try?).

@Etaash-mathamsetty
Copy link
Member

Etaash-mathamsetty commented Jan 10, 2025

The main thing I want to avoid with this PR is users using something unstable by default or by mistake, but let them use experimental if they need to (would experimental have fixes before ge-proton for example that users may want to try?).

maybe add an option that allows showing all the proton versions (where it's off by default)

@gabriele2000
Copy link

I mean, Proton Experimental isn't so experimental... the real experimental thing is proton-experimental-bleeding-edge or something like that.

Proton experimental is just updated every few weeks, Proton stable, uh...

@Etaash-mathamsetty
Copy link
Member

I mean, Proton Experimental isn't so experimental... the real experimental thing is proton-experimental-bleeding-edge or something like that.

Proton experimental is just updated every few weeks, Proton stable, uh...

proton experimental isn't recommended to be run with umu because it doesn't contain protonfixes + some other patches

@gabriele2000
Copy link

proton experimental isn't recommended to be run with umu because it doesn't contain protonfixes + some other patches

Then I suggest you to negate Proton Experimental only if UMU is enabled (enable UMU by default but let the user choose to disable it)

@arielj
Copy link
Collaborator Author

arielj commented Jan 18, 2025

The changes here are aimed to the general user to not, by default, end with a setup that is not recommended (the second problem with experimental is that an update breaks something you can't easily rollback to the working version, but if using proton-ge-latest for example and an update breaks something you can easily change to another fixed version using the wine manager).

The intention of this is to prevent users who don't know what they are doing to use something they don't know how to handle properly. The option to continue using experimental and enable/disable umu as needed will be there for any user who wants to try that.

@gabriele2000
Copy link

The changes here are aimed to the general user to not, by default, end with a setup that is not recommended (the second problem with experimental is that an update breaks something you can't easily rollback to the working version, but if using proton-ge-latest for example and an update breaks something you can easily change to another fixed version using the wine manager).

The intention of this is to prevent users who don't know what they are doing to use something they don't know how to handle properly. The option to continue using experimental and enable/disable umu as needed will be there for any user who wants to try that.

Awesome, thanks for the clarification!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr:ready-for-review Feature-complete, ready for the grind! :P
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants