Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

names(generic_fhd_bootstraps) #28

Open
JannisLi opened this issue Feb 17, 2023 · 1 comment
Open

names(generic_fhd_bootstraps) #28

JannisLi opened this issue Feb 17, 2023 · 1 comment
Assignees

Comments

@JannisLi
Copy link

JannisLi commented Feb 17, 2023

Hi,
just a minor thing. But when looking at the names in
names(generic_fhd_bootstraps)
you can see that there is a small inconsistency:

Great_Black_backed_Gull
Lesser_Black_Backed_Gull

the later having a capital "B" in backed.

The thing is that most people probably will write it one way or the other . but then you either get a error message for GBBG or LBBG. I received e.g. Running Scenario: scenario_2 [===========================>---------------------------] 50% eta: 2hError in validate_inputs():
! ✖ Missing argument gen_fhd_boots with no default:
gen_fhd_boots required for model_options '2' and/or '3'.
ℹ Calculations under Model Options 2 and 3 require a generic FHD.

toke me moment to figure out why.
Perhaps you could change the spelling at one point.
Cheers
Jannis

@bcaneco
Copy link
Collaborator

bcaneco commented Feb 23, 2023

Thanks for pointing that out Jannis.

That's an issue with input pre-processing, not so much with the package itself. However, it's part of the shipped data and it's implied in the provided examples - so I completely take you point! :)

We'll amend the names of the generic_fhd_bootstraps list and make sure they are as consistent as possible.

@bcaneco bcaneco self-assigned this Feb 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants