Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up project #38

Closed
10 tasks done
Wylwi opened this issue Oct 14, 2024 · 1 comment
Closed
10 tasks done

Clean up project #38

Wylwi opened this issue Oct 14, 2024 · 1 comment
Assignees
@Wylwi

Comments

@Wylwi
Copy link
Contributor

Wylwi commented Oct 14, 2024 •
edited
Loading

  • Remove Template useless files, check that nothing related to "Sample app" is left
    • Change the name of the project to Hike Mate so that the Android Studio project has title "Hike Mate" instead of "SampleApp"
  • Add theme from Figma (Font, colors, font sizes, etc.)
  • Clean up app/build.gradle.kts
  • Change sonar rule to 80% code coverage on all code, not only new code
  • Multiple Junit in libs
  • Multiple sonar tasks in CI
  • Similar step CI name ("Run tests" and "run tests")
  • Fix Sonar issues
  • List issues that should not be reproduced somewhere so they get added to the wiki (adding them to the wiki itself is not part of the task)
@Wylwi Wylwi self-assigned this Oct 14, 2024
Wylwi added a commit that referenced this issue Oct 15, 2024
@Wylwi
chore: clean the project from template files (#38) (#42)
0185743 
* chore: remove unused dependencies

* chore: reorganize dependencies and remove old ones

* chore: bump AGP and android sdk version

* chore: remove template files and rename to real project name

* chore: change color theme to the real one

* fix: lower targetSdk android version

Roboelectric is not yet compatible with SDK 35

* ci: remove useless duplicated step

Sonar was run twice

* fix: deny use of cleartext connection

* chore: add line break to pull request template

* fix: remove jacoco incorrect line bug

Jacoco has a bug where he put line coverage to line 65535, which is an error. The code snippet is extracted from https://medium.com/@theilacker/fixing-sonarqube-line-out-of-range-issue-when-using-jetpack-compose-5ba4c1f361f1
@Wylwi
Copy link
Contributor Author

Wylwi commented Oct 15, 2024

Closed by #42

@Wylwi Wylwi closed this as completed Oct 15, 2024
@rBergCode rBergCode mentioned this issue Oct 16, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Wylwi Wylwi

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

When branches are created from issues, their pull requests are automatically linked.

refs/heads/38-clean-up-project HikeMate/hikeMateApp
1 participant
@Wylwi