Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Math.random() is not a secure way to generate salt #3

Open
julius-welink opened this issue Feb 15, 2023 · 0 comments
Open

Math.random() is not a secure way to generate salt #3

julius-welink opened this issue Feb 15, 2023 · 0 comments

Comments

@julius-welink
Copy link

I see a couple of problems with this lib:

  1. It is using Math.random() to generate salt values. Which is not a cryptographically secure method of generating randomness.
  2. For some reason it implements its own MD5.

Just a note for someone considering using this.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@julius-welink