-
-
Notifications
You must be signed in to change notification settings - Fork 9.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
brew install --cask docker
fails after having done brew install docker
#16309
Comments
It seems like there were some lingering files from a previous installation of Docker that were causing conflicts during the reinstallation process. To resolve this issue, you successfully identified and removed these files. |
This is a known issue that it's unclear how to be solved. There may already be a homebrew/cask issue for this CC @Homebrew/cask for help triaging. Need to decide how best to handle this e.g. what symlinks to install/skip/etc. |
The failures are coming from Would say this is related to Homebrew/homebrew-cask#12822 as we do specify the conflict but it is only documentation (e.g. https://formulae.brew.sh/cask/docker#default) rather than providing a useful error when user tries following:
|
not sure whether this conversation should be here or there but: I don't think this should be an error at all. Instead, either the formula or cask should not be linked and the user warned. |
Was basing this on how formulae are currently handled, e.g.
EDIT: Though we may be handling the reverse situation for Cask-Formula conflict: brew/Library/Homebrew/formula_installer.rb Lines 973 to 982 in dde0411
|
Yeh, we should do something similar to that, I think, but expand the definitions so that they don't need to have the same name.
I think this makes sense for formulae that are often mutually exclusive. For formula/cask combos when it seems many people often want both: it kinda sucks. |
Please someone do something to prevent users from doing |
I want the former since I'm using a different container runtime and a lot of tools hardcode the docker command. |
Same here. The |
My bad. But I suspect my main point still stands -- there's a sharp edge here that could maybe be smoothed over. Usually Is it possible for the Homebrew team to do something so that devs don't install the wrong thing by mistake and then have to dig out this issue to fix it? Shouldn't the package be named |
No. It's usually
No. The cask could be renamed if we want to go down that route. |
I know it's a breaking change, so maybe not feasible, but for me the ideal fix for this would be for brew were to error on ambiguous cask vs formula install commands. This is the way it works if a formula is available in multiple taps. That would force people to actually work out which one they wanted. |
Yea, this maybe should've been what we did from the beginning. But this will break too many things now to change, unfortunately. |
It could be optional behaviour, though. I can see people (perhaps myself included) enabling that. Alternatively, it is something we could consider just warning and later deprecating/erroring on. |
This is still my favoured option, though; at least in homebrew/core and homebrew/cask we should just avoid overlapping names like we do. |
Yeah a "there is also a cask for this, if you wanted that cancel this install and do |
ty! my docker broke after upgrading to Sequoia (v15.0). I can confirm that after applying all of those |
I've tried everything to get it to work.
I'm sure I can manualyl install from the docker website but at this point I want to know why I can't get brew to work |
Try |
brew doctor
outputVerification
brew doctor
output" above saysYour system is ready to brew.
and am still able to reproduce my issue.brew update
twice and am still able to reproduce my issue.brew install wget
. If they do, open an issue at https://github.com/Homebrew/homebrew-core/issues/new/choose instead.brew config
outputWhat were you trying to do (and why)?
I was trying to install Docker via brew in order to run Docker. With that I mean that I wanted to have Docker and the Docker engine.
What happened (include all command output)?
What did you expect to happen?
Successful installation of the Docker cask.
Step-by-step reproduction instructions (by running
brew
commands)The text was updated successfully, but these errors were encountered: