-
-
Notifications
You must be signed in to change notification settings - Fork 10.8k
github_packages: Bump to Sorbet typed: strict
#21186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
5103811 to
5306989
Compare
5306989 to
1573c8c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This pull request upgrades the github_packages.rb file from Sorbet's typed: true level to typed: strict, which requires explicit type annotations for all methods and instance variables. This is part of a broader effort tracked in issue #17297 to improve type safety across the Homebrew codebase.
Key Changes
- Upgraded Sorbet sigil from
typed: truetotyped: strict - Added
T.lettype annotations to string constants (URL_PREFIX, DOCKER_PREFIX) - Added type annotations to hash constants with explicit hash types
- Added method signatures (
sigblocks) to all methods including complex return types
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
MikeMcQuaid
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
https://github.com/Homebrew/homebrew-core/actions/runs/20006761802/job/57370185501 |
brew lgtm(style, typechecking and tests) with your changes locally?typed: strictin all (non-package) files in Homebrew organisation #17297.