Skip to content

Conversation

@issyl0
Copy link
Member

@issyl0 issyl0 commented Dec 6, 2025

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew lgtm (style, typechecking and tests) with your changes locally?

@issyl0 issyl0 force-pushed the srb-github-packages branch 2 times, most recently from 5103811 to 5306989 Compare December 6, 2025 17:57
@issyl0 issyl0 force-pushed the srb-github-packages branch from 5306989 to 1573c8c Compare December 6, 2025 18:11
@issyl0 issyl0 marked this pull request as ready for review December 6, 2025 18:45
Copilot AI review requested due to automatic review settings December 6, 2025 18:45
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request upgrades the github_packages.rb file from Sorbet's typed: true level to typed: strict, which requires explicit type annotations for all methods and instance variables. This is part of a broader effort tracked in issue #17297 to improve type safety across the Homebrew codebase.

Key Changes

  • Upgraded Sorbet sigil from typed: true to typed: strict
  • Added T.let type annotations to string constants (URL_PREFIX, DOCKER_PREFIX)
  • Added type annotations to hash constants with explicit hash types
  • Added method signatures (sig blocks) to all methods including complex return types

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@MikeMcQuaid MikeMcQuaid added this pull request to the merge queue Dec 7, 2025
Merged via the queue into main with commit 3962ab8 Dec 7, 2025
43 checks passed
@MikeMcQuaid MikeMcQuaid deleted the srb-github-packages branch December 7, 2025 16:02
@botantony
Copy link
Member

botantony commented Dec 7, 2025

Error: Parameter 'version': Expected type Version, got type String with value "3.14.2"
Caller: /home/linuxbrew/.linuxbrew/Homebrew/Library/Homebrew/github_packages.rb:247
Definition: /home/linuxbrew/.linuxbrew/Homebrew/Library/Homebrew/github_packages.rb:89 (GitHubPackages.version_rebuild)
/home/linuxbrew/.linuxbrew/Homebrew/Library/Homebrew/vendor/bundle/ruby/3.4.0/gems/sorbet-runtime-0.6.12798/lib/types/configuration.rb:293:in 'T::Configuration.call_validation_error_handler_default'
/home/linuxbrew/.linuxbrew/Homebrew/Library/Homebrew/vendor/bundle/ruby/3.4.0/gems/sorbet-runtime-0.6.12798/lib/types/configuration.rb:300:in 'T::Configuration.call_validation_error_handler'
/home/linuxbrew/.linuxbrew/Homebrew/Library/Homebrew/vendor/bundle/ruby/3.4.0/gems/sorbet-runtime-0.6.12798/lib/types/private/methods/call_validation.rb:322:in 'T::Private::Methods::CallValidation.report_error'
/home/linuxbrew/.linuxbrew/Homebrew/Library/Homebrew/vendor/bundle/ruby/3.4.0/gems/sorbet-runtime-0.6.12798/lib/types/private/methods/call_validation.rb:230:in 'block in T::Private::Methods::CallValidation.validate_call'
/home/linuxbrew/.linuxbrew/Homebrew/Library/Homebrew/vendor/bundle/ruby/3.4.0/gems/sorbet-runtime-0.6.12798/lib/types/private/methods/signature.rb:213:in 'T::Private::Methods::Signature#each_args_value_type'
/home/linuxbrew/.linuxbrew/Homebrew/Library/Homebrew/vendor/bundle/ruby/3.4.0/gems/sorbet-runtime-0.6.12798/lib/types/private/methods/call_validation.rb:227:in 'T::Private::Methods::CallValidation.validate_call'
/home/linuxbrew/.linuxbrew/Homebrew/Library/Homebrew/vendor/bundle/ruby/3.4.0/gems/sorbet-runtime-0.6.12798/lib/types/private/methods/_methods.rb:259:in 'block in GitHubPackages._on_method_added'
/home/linuxbrew/.linuxbrew/Homebrew/Library/Homebrew/github_packages.rb:247:in 'GitHubPackages#preupload_check'
/home/linuxbrew/.linuxbrew/Homebrew/Library/Homebrew/vendor/bundle/ruby/3.4.0/gems/sorbet-runtime-0.6.12798/lib/types/private/methods/call_validation.rb:282:in 'UnboundMethod#bind_call'
/home/linuxbrew/.linuxbrew/Homebrew/Library/Homebrew/vendor/bundle/ruby/3.4.0/gems/sorbet-runtime-0.6.12798/lib/types/private/methods/call_validation.rb:282:in 'T::Private::Methods::CallValidation.validate_call'
/home/linuxbrew/.linuxbrew/Homebrew/Library/Homebrew/vendor/bundle/ruby/3.4.0/gems/sorbet-runtime-0.6.12798/lib/types/private/methods/_methods.rb:259:in 'block in GitHubPackages#_on_method_added'
/home/linuxbrew/.linuxbrew/Homebrew/Library/Homebrew/github_packages.rb:73:in 'block in GitHubPackages#upload_bottles'
/home/linuxbrew/.linuxbrew/Homebrew/Library/Homebrew/github_packages.rb:71:in 'Hash#each'
/home/linuxbrew/.linuxbrew/Homebrew/Library/Homebrew/github_packages.rb:71:in 'GitHubPackages#upload_bottles'
/home/linuxbrew/.linuxbrew/Homebrew/Library/Homebrew/vendor/bundle/ruby/3.4.0/gems/sorbet-runtime-0.6.12798/lib/types/private/methods/call_validation.rb:282:in 'UnboundMethod#bind_call'
/home/linuxbrew/.linuxbrew/Homebrew/Library/Homebrew/vendor/bundle/ruby/3.4.0/gems/sorbet-runtime-0.6.12798/lib/types/private/methods/call_validation.rb:282:in 'T::Private::Methods::CallValidation.validate_call'
/home/linuxbrew/.linuxbrew/Homebrew/Library/Homebrew/vendor/bundle/ruby/3.4.0/gems/sorbet-runtime-0.6.12798/lib/types/private/methods/_methods.rb:259:in 'block in GitHubPackages#_on_method_added'
/home/linuxbrew/.linuxbrew/Homebrew/Library/Homebrew/dev-cmd/pr-upload.rb:112:in 'Homebrew::DevCmd::PrUpload#run'
/home/linuxbrew/.linuxbrew/Homebrew/Library/Homebrew/vendor/bundle/ruby/3.4.0/gems/sorbet-runtime-0.6.12798/lib/types/private/methods/call_validation.rb:282:in 'UnboundMethod#bind_call'
/home/linuxbrew/.linuxbrew/Homebrew/Library/Homebrew/vendor/bundle/ruby/3.4.0/gems/sorbet-runtime-0.6.12798/lib/types/private/methods/call_validation.rb:282:in 'T::Private::Methods::CallValidation.validate_call'
/home/linuxbrew/.linuxbrew/Homebrew/Library/Homebrew/vendor/bundle/ruby/3.4.0/gems/sorbet-runtime-0.6.12798/lib/types/private/methods/_methods.rb:259:in 'block in Homebrew::DevCmd::PrUpload#_on_method_added'
/home/linuxbrew/.linuxbrew/Homebrew/Library/Homebrew/brew.rb:101:in '<main>'

https://github.com/Homebrew/homebrew-core/actions/runs/20006761802/job/57370185501

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants