Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem with value == 0. #1

Open
vegansk opened this issue Sep 16, 2016 · 2 comments
Open

Problem with value == 0. #1

vegansk opened this issue Sep 16, 2016 · 2 comments

Comments

@vegansk
Copy link

vegansk commented Sep 16, 2016

Option's value of 0 is handled like there is no value. Sometimes 0 must be a valid identifier.

@vegansk
Copy link
Author

vegansk commented Sep 16, 2016

It happens with v0.1.3, maybe it's fixed in master, can't check. npm install fails with:

43 error addLocal Could not install /tmp/vega/npm-12680-c7277e78/git-cache-9d6c932e/6c7e45cd316c8e6e40bf972c2c5f39e6ea3a4e84
44 silly fetchPackageMetaData Error: No version provided in package.json

@HriBB
Copy link
Owner

HriBB commented Sep 16, 2016

Hello @vegansk.

Uhh sorry about that, but this project is in a bit of a mess ATM. I am in the process of rewriting all components to be completely stateless. After that, SelectField will become a part ofreact-mdl-extra` and this package will be deprecated. I was hoping to do it this week, but I was pretty busy at work. In the meantime, you can fork the repo (I think that this commit has the latest statefull code.

Anyway, the idea is to group all components that do not fit into react-mdl into a common react-mdl-extra package. Here's the preview and the examples.

SelectField uses the new Dropdown component which uses react-portal to render itself into the body (no more overflow:hidden problems).

Let me know if I can help you anyhow ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants