Avoid jdk8 incompatible code in CodeStyleTest#835
Merged
rbri merged 1 commit intoHtmlUnit:masterfrom Jul 31, 2024
Merged
Conversation
Member
|
Thanks a lot - how did you found this as the test are only compiling with JDK 11. do you use some kind of a checker? |
Contributor
Author
|
IntelliJ complained about it. There are other problems I’ve had to work around, but this one seemed simple enough. I had also seen another commit that changed a Path.of to Paths.get so I assumed it was the intent to keep code as jdk8 friendly as possible. |
Member
|
Ah ok, i use IntelliJ from time to time but eclipse most of the time. But for the lib build jdk 8 is still sufficient. you can use something like to deploy a local snapshot with jdk 8 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Jdk8 doesn't support
Path.ofyet, so we should revert toPaths.get.