Skip to content

Comments

Avoid jdk8 incompatible code in CodeStyleTest#835

Merged
rbri merged 1 commit intoHtmlUnit:masterfrom
Crydust:kristof/jdk8
Jul 31, 2024
Merged

Avoid jdk8 incompatible code in CodeStyleTest#835
rbri merged 1 commit intoHtmlUnit:masterfrom
Crydust:kristof/jdk8

Conversation

@Crydust
Copy link
Contributor

@Crydust Crydust commented Jul 30, 2024

Jdk8 doesn't support Path.of yet, so we should revert to Paths.get.

@rbri rbri merged commit e1b3ed2 into HtmlUnit:master Jul 31, 2024
@rbri
Copy link
Member

rbri commented Jul 31, 2024

Thanks a lot - how did you found this as the test are only compiling with JDK 11. do you use some kind of a checker?

@Crydust
Copy link
Contributor Author

Crydust commented Jul 31, 2024

IntelliJ complained about it. There are other problems I’ve had to work around, but this one seemed simple enough. I had also seen another commit that changed a Path.of to Paths.get so I assumed it was the intent to keep code as jdk8 friendly as possible.

@rbri
Copy link
Member

rbri commented Jul 31, 2024

Ah ok, i use IntelliJ from time to time but eclipse most of the time.
The test are requiring a JDK 11 because the selenium stuff is at jdk 11.

But for the lib build jdk 8 is still sufficient.

you can use something like

mvn deploy -Dmaven.test.skip=true

to deploy a local snapshot with jdk 8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants