Skip to content

Commit b2b98b0

Browse files
authored
Merge pull request #1759 from dalazx/logging_statement_fix
Fixed a logging statement
2 parents 11804ae + ea477e6 commit b2b98b0

File tree

1 file changed

+3
-2
lines changed

1 file changed

+3
-2
lines changed

SingularityService/src/main/java/com/hubspot/singularity/scheduler/SingularityDeployHealthHelper.java

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -154,8 +154,9 @@ private boolean isRunningTaskHealthy(final Optional<SingularityDeploy> deploy, C
154154
Optional<SingularityTaskHistoryUpdate> runningUpdate = SingularityTaskHistoryUpdate.getUpdate(updates, ExtendedTaskState.TASK_RUNNING);
155155
long taskDuration = System.currentTimeMillis() - runningUpdate.get().getTimestamp();
156156

157-
if (taskDuration < TimeUnit.SECONDS.toMillis(runningThreshold)) {
158-
LOG.debug("Task {} has been running for {}, has not yet reached running threshold of {}", taskId, JavaUtils.durationFromMillis(taskDuration), JavaUtils.durationFromMillis(runningThreshold));
157+
long runningThresholdMillis = TimeUnit.SECONDS.toMillis(runningThreshold);
158+
if (taskDuration < runningThresholdMillis) {
159+
LOG.debug("Task {} has been running for {}, has not yet reached running threshold of {}", taskId, JavaUtils.durationFromMillis(taskDuration), JavaUtils.durationFromMillis(runningThresholdMillis));
159160
return false;
160161
}
161162
return true;

0 commit comments

Comments
 (0)