Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid looping through objects if there are no pre/post export hooks defined. #127

Open
Exairnous opened this issue Sep 15, 2022 · 0 comments
Labels

Comments

@Exairnous
Copy link
Contributor

Is your feature request related to a problem? Please describe.
The pre/post export hooks loop through objects even if there are no hooks to be applied.

Describe the solution you'd like
A way to bypass looping through objects if there are no hooks present.

The solution that comes to my mind is to check for hooks when building the components registry and populate a list of export hooks, then check to see if that list has any hooks before looping through all of the objects, if it doesn't then return without looping (this could also be accomplished by using a bool instead of a list).

Describe alternatives you've considered
Modifying the hooks to always return early (effectively disabling them) until we need them, but this isn't ideal as it would cause 3rd party developers to have to re-enable the hooks locally before they could add in hooks to their custom definitions.

@keianhzo keianhzo added P1 Address as quickly as possible improvement labels Sep 19, 2022
@keianhzo keianhzo added P2 Address when able Backlog and removed P1 Address as quickly as possible labels Mar 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants