Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure correct values are displayed in guidelines for boolean fields #1397

Open
ESapenaVentura opened this issue Jul 26, 2021 · 0 comments
Open
Labels
content Any PR that incorporates changes to the schema

Comments

@ESapenaVentura
Copy link
Collaborator

For which schema is a change/update being suggested?

  • json_schema/module/project/contact.json
  • json_schema/module/process/sequencing/10x.json
  • json_schema/type/protocol/sequencing/sequencing_protocol.json
  • json_schema/type/project/project.json

What should the change/update be?

The following fields should have their examples updated to reflect the acceptable value in the json file, rather than the user friendly inputs:

  • json_schema/module/project/contact.json: corresponding_contributor property
  • json_schema/module/process/sequencing/10x.json: drop_uniformity property
  • json_schema/type/protocol/sequencing/sequencing_protocol.json: paired_end property
  • json_schema/type/project/project.json: official_hca_publication property (Not yet available, in PR discussion now)

This update constitutes a patch change to the schema(s) it affects.

Why is the change requested?

As per the discussion going on in the PR https://github.com/HumanCellAtlas/metadata-schema/pull/1396/files#r665483651, it was pointed out that example field. of the properties should reflect the contents of the JSON files and not reflect the implementation of how the schema is presented to the user.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content Any PR that incorporates changes to the schema
Projects
None yet
Development

No branches or pull requests

1 participant