Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed typo on normalisation field values. Fixes #1410. #1499

Merged
merged 3 commits into from
Oct 31, 2022
Merged

Fixed typo on normalisation field values. Fixes #1410. #1499

merged 3 commits into from
Oct 31, 2022

Conversation

ESapenaVentura
Copy link
Collaborator

Release notes

For module/protocol/matrix.json schema:

  • Fixed apostrophe in normalisation field enum values

Impact prevision

  • This is a major update, but since no data has used that value yet and it's on the values, there shouldn't be any major impact

@ESapenaVentura ESapenaVentura added the content Any PR that incorporates changes to the schema label Oct 18, 2022
@ESapenaVentura ESapenaVentura self-assigned this Oct 18, 2022
@ESapenaVentura ESapenaVentura mentioned this pull request Oct 18, 2022
Closed
2 tasks
amnonkhen
amnonkhen reviewed Oct 20, 2022
View reviewed changes
Copy link
Collaborator

@amnonkhen amnonkhen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we add checking for illegal characters such as ` to the schema linter?

@ESapenaVentura
Copy link
Collaborator Author

@amnonkhen that is a good idea, but probably out of the scope of this PR! I have created a ticket #1501

@ESapenaVentura ESapenaVentura mentioned this pull request Oct 31, 2022
Open
2 tasks
@ESapenaVentura ESapenaVentura merged commit f9a8690 into staging Oct 31, 2022
@ESapenaVentura ESapenaVentura deleted the esv-apostrophe-Issue1410 branch October 31, 2022 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amnonkhen amnonkhen amnonkhen left review comments

@ncalvanese1 ncalvanese1 ncalvanese1 approved these changes

@hannes-ucsc hannes-ucsc hannes-ucsc approved these changes

@NoopDog NoopDog NoopDog approved these changes

Assignees

@ESapenaVentura ESapenaVentura

Labels
content Any PR that incorporates changes to the schema
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ESapenaVentura @amnonkhen @NoopDog @hannes-ucsc @ncalvanese1