Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(Un)locking a private channel makes it public #347

Closed
tempest15 opened this issue May 9, 2023 · 2 comments · Fixed by #395
Closed

(Un)locking a private channel makes it public #347

tempest15 opened this issue May 9, 2023 · 2 comments · Fixed by #395
Labels
T: bug Something isn't working

Comments

@tempest15
Copy link
Member

This is likely an issue of needing to handle the roles that have access rather than the everyone role.
@tempest15 tempest15 added the T: bug Something isn't working label May 9, 2023
@tempest15
Copy link
Member Author

After further investigation, it seems like this requires a rewrite of the locking system to use the database. The original permission set needs to be stored when the channel is locked, and used when it's unlocked. The system that checks for locking should also be rewritten alongside.

@NoComment1105 NoComment1105 mentioned this issue Apr 10, 2024
Merged
@NoComment1105 NoComment1105 linked a pull request Apr 10, 2024 that will close this issue
Fix permissions being lost by locked channels when unlocked #395
Merged
@NoComment1105
Copy link
Member

Fixed by #395. This will be included in 5.0.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
T: bug Something isn't working
Projects
LilyBot 5.0.0
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix permissions being lost by locked channels when unlocked HyacinthBots/LilyBot
2 participants
@tempest15 @NoComment1105