Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does not remember initial settings #12

Open
maystorm opened this issue Aug 9, 2024 · 2 comments
Open

Does not remember initial settings #12

maystorm opened this issue Aug 9, 2024 · 2 comments

Comments

@maystorm
Copy link

maystorm commented Aug 9, 2024

A great mod/datapack.

However, I've frequently encountered that the settings in the datapack are ignored and fall back to their vanilla stack sizes.

I know that this is just a very vague description of what happens. If the author is committed to improve this datapack at a long-term timeframe I can offer to dig deeper into this issue and try to track down at what circumstances exactly the misbehaviour happens. At a first glance I can't see what causes the problem but again, I'd be willing to dig deeper into it if the author wishes so.

@HydraheadHunter
Copy link
Owner

HydraheadHunter commented Aug 10, 2024

I get easily distracted, but yes I'd be quite happy to improve the mod.

Please do return with more info, particularly:

  • Are you experiencing the issue in single player, multiplayer, or both.
  • Are you experiencing the issue on start up, datapack reloading, or regular gameplay?
  • Are you experiencing the issue with item stack sizes less than 100, greater than 99, or both?
  • What items have you experienced the issue with: what stack sizes were they supposed to have? (Just pop the whole datapack in a zip and attach it if you would be so kind.)
  • Is the issue lossy (That is when the item stack size resets to default, do over-stacked stacks lose items).
  • What other mods and datapacks are you running?

@HydraheadHunter
Copy link
Owner

My best guess with none info is that it's a JSON loading issue.

If you edit the JSONs and their incorrectly formatted minecraft throws a fit and refuses to load the tag in its entirety. Double check your jsons for missing, out of place, and extra commas or try using the mod mod in-conjunction with Load My Fucking Tags, to see if the problems persists.

I'd love to look further into the cause of any issue, once there's additional info about it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants