move state changes before settlement

davidqhr · davidqhr · commit 136b4d9417bc · 2019-03-11T14:03:30.000+08:00
diff --git a/contracts/HybridExchange.sol b/contracts/HybridExchange.sol
@@ -157,10 +157,10 @@ contract HybridExchange is LibMath, LibOrder, LibRelayer, LibDiscount, LibExchan
             filled[makerOrderInfo.orderHash] = makerOrderInfo.filledAmount;
         }
 
-        settleResults(results, takerOrderParam, orderAddressSet);
-
         // Update amount filled for this taker order.
         filled[takerOrderInfo.orderHash] = takerOrderInfo.filledAmount;
+
+        settleResults(results, takerOrderParam, orderAddressSet);
     }
 
     /**

Original file line number	Diff line number	Diff line change
`@@ -157,10 +157,10 @@ contract HybridExchange is LibMath, LibOrder, LibRelayer, LibDiscount, LibExchan`
`157`	`157`	`filled[makerOrderInfo.orderHash] = makerOrderInfo.filledAmount;`
`158`	`158`	`}`
`159`	`159`
`160`		`- settleResults(results, takerOrderParam, orderAddressSet);`
`161`		`-`
`162`	`160`	`// Update amount filled for this taker order.`
`163`	`161`	`filled[takerOrderInfo.orderHash] = takerOrderInfo.filledAmount;`
	`162`	`+`
	`163`	`+ settleResults(results, takerOrderParam, orderAddressSet);`
`164`	`164`	`}`
`165`	`165`
`166`	`166`	`/**`