Scanner fails with '/dev/tty: Device not configured' when run non-interactively

[mrtwebdesign]

Summary

When running check-performance.sh from a non-interactive context (e.g., AI assistant, CI/CD, subprocess), the scanner fails with multiple /dev/tty: Device not configured errors and does not generate HTML reports or log files.

Steps to Reproduce

1. Run the scanner from a non-interactive shell (no TTY attached):

./dist/bin/check-performance.sh --paths /path/to/theme --format json

2. Observe errors at the end of execution:

/Users/.../check-performance.sh: line 5537: /dev/tty: Device not configured
/Users/.../check-performance.sh: line 5541: /dev/tty: Device not configured
/Users/.../check-performance.sh: line 5605: /dev/tty: Device not configured
/Users/.../check-performance.sh: line 5606: /dev/tty: Device not configured

Expected Behavior

Scanner should detect non-interactive mode and either:

• Skip interactive prompts entirely
• Use sensible defaults when TTY is unavailable
• Provide a --non-interactive or --batch flag

Actual Behavior

• JSON output is printed to stdout (works)
• HTML report is NOT generated
• Log file may not be written
• Exit code is 1 (unclear if from findings or TTY errors)

Environment

• macOS Darwin 24.6.0
• Scanner version: 1.2.4
• Context: Running from Claude Code (AI assistant without TTY)

Suggested Fix

Check for TTY availability before prompting:

if [ -t 0 ]; then
    # Interactive prompts OK
else
    # Use defaults or skip
fi

Impact

Blocks AI-assisted workflows and CI/CD integration when HTML reports are needed.

[noelsaw1]

#79

[mrtwebdesign]

Fix Verification for Commit d09d06f

Tested the fix in a non-interactive context (Claude Code). Here's what I found:

Test Results

Aspect	Before Fix	After Fix
TTY Errors	4 errors to stderr	✅ No errors
JSON to stdout	✅ Works	✅ Works
JSON log file	❌ Not created	✅ Created
HTML report	❌ Not created	❌ Still not created

What's Happening

The commit added great new features (init, update, tab completion) with proper TTY detection. However, the original HTML generation code (lines 5848-5863) still writes to /dev/tty unconditionally:

# No TTY check here
if "$SCRIPT_DIR/json-to-html.py" "$LOG_FILE" "$HTML_REPORT" > /dev/tty 2>&1; then
  echo "📊 HTML Report: $HTML_REPORT" > /dev/tty

The errors disappeared because bash silently ignores failed redirects (no set -e). The HTML generation runs but output goes nowhere.

Verified: Running with script -q /dev/null (provides pseudo-TTY) DOES generate HTML — confirming TTY is the issue.

Current Behavior

Context	JSON	HTML	User Experience
Terminal	✅	✅	Works fully
CI / AI assistants	✅	❌	Silent skip — no indication HTML was skipped

Suggested Addition

Wrap the HTML generation block with TTY detection (similar to what was done for init/update):

if [ -t 1 ]; then
  # Interactive: output to /dev/tty
  "$SCRIPT_DIR/json-to-html.py" "$LOG_FILE" "$HTML_REPORT" > /dev/tty 2>&1
  echo "📊 HTML Report: $HTML_REPORT" > /dev/tty
else
  # Non-interactive: generate silently, report path to stderr  
  "$SCRIPT_DIR/json-to-html.py" "$LOG_FILE" "$HTML_REPORT" 2>/dev/null
  echo "HTML Report: $HTML_REPORT" >&2
fi

This ensures HTML is generated in both contexts, with appropriate output handling.

---

The new shell features look great — just needs this small addition to complete the non-interactive support.