Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review usage of prettier dependency #1990

Open
johnaohara opened this issue Sep 14, 2024 · 3 comments
Open

Review usage of prettier dependency #1990

johnaohara opened this issue Sep 14, 2024 · 3 comments
Labels
area/dependency Dependency Upgrade area/UI priority/low Low priority

Comments

@johnaohara
Copy link
Member

Describe the bug

Horreum-web module imports the prettier dependency, which is referenced in the prettier-format script

Review usage of the dependency to determine if it is used, whether is should be used, removed or replaced

@johnaohara johnaohara added area/UI priority/low Low priority area/dependency Dependency Upgrade labels Sep 14, 2024
@shivam-sharma7
Copy link
Member

@johnaohara If you want to proper utilize this dep.. then pre-commit hooks can help us in order to format horreum-web module codebase.

@johnaohara
Copy link
Member Author

Hi @shivam-sharma7, hope you are well!
thanks for the input. This issue was opened because we are not using this dependency atm.
We have just re-introduced code formatting on the java part of the project with an auto-formatter that is tied to the build lifecycle: 285ec51

I opened this issue with the intention of reviewing whether we can use the new formatter with the .TS code as well.

We have had problems in the past with git hooks working transparently across all envs (win,linux, macos) and was hoping we could tie it into the maven build lifecycle

@shivam-sharma7
Copy link
Member

Hi @shivam-sharma7, hope you are well!

@johnaohara I'm good, what about you?

I opened this issue with the intention of reviewing whether we can use the new formatter with the .TS code as well.

If you can format TS code via new formatter then prettier no longer needed

We have had problems in the past with git hooks working transparently across all envs (win,linux, macos) and was hoping we could tie it into the maven build lifecycle

Yeah, I remember

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/dependency Dependency Upgrade area/UI priority/low Low priority
Projects
None yet
Development

No branches or pull requests

2 participants