Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use a single jsonpath dialect #2038

Open
willr3 opened this issue Sep 30, 2024 · 1 comment
Open

Use a single jsonpath dialect #2038

willr3 opened this issue Sep 30, 2024 · 1 comment

Comments

@willr3
Copy link
Collaborator

willr3 commented Sep 30, 2024

Feature idea.
Horreum currently uses a different jsonpath dialect for extracting the start and stop in addRunFromData than it does for all the Extractors. This effectively adds cognitive complexity to the user so that Horreum development is easier.

Horreum should provide a consistent means of defining jsonpaths across all features.

@willr3
Copy link
Collaborator Author

willr3 commented Sep 30, 2024

I think we have two options:

  1. Extract the start and stop using postgresql's dailect by creating a database table where the data can be stored and the extractors can be tested.
  2. Create something to translate between whatever jsonpath dialect we provide users and the various jsonpath dialects that are used within Horreum.

Option 1. is probably the easiest to implement but it maintains the hard dependency on Postgres.
Option 2 is the hardest to implement and honestly the only upside I see is it gives Horreum the ability to transition away from Postgres if needed.

I think options 2 is interesting but it would take a lot longer to implement and the benefit over option 1 is not something Horreum would use in the near term.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant