Skip to content
This repository has been archived by the owner on Jan 31, 2023. It is now read-only.

Re-enforce audit & set levels #2815

Closed
2 tasks
Jakeeyturner opened this issue Nov 12, 2020 · 2 comments
Closed
2 tasks

Re-enforce audit & set levels #2815

Jakeeyturner opened this issue Nov 12, 2020 · 2 comments
Labels
build p1 wontfix This will not be worked on
Milestone
Sprint 44

Comments

@Jakeeyturner
Copy link
Contributor

Jakeeyturner commented Nov 12, 2020 •
edited
Loading

Description

  1. We should re-enforce our npm audit
  2. Currently we run it in every job (every unit test job, every cucumber test job...), we should just have it in one place - maybe before a release?
  3. If npm audit finds high/critical severity, we should fail/error. However, if they are low/medium, we should continue with the job.
  4. We should probably do an audit fix!

Expected Behavior

Actual Behavior

Possible Fix

Steps to Reproduce

Existing issues

Log File

Your Environment

  • IBM Blockchain Platform Extension Version:
  • Visual Studio Code version:
  • Environment name and version (e.g. Node.js v8.12.0, npm v6.4.1):
  • Operating System and version:
  • Link to your project:
@Jakeeyturner Jakeeyturner added this to the Sprint 43 milestone Dec 7, 2020
@Jakeeyturner Jakeeyturner modified the milestones: Sprint 43, Sprint 44 Dec 18, 2020
@lquintai lquintai self-assigned this Jan 8, 2021
@lquintai lquintai mentioned this issue Jan 8, 2021
Closed
@lquintai lquintai mentioned this issue Feb 1, 2021
Closed
@jt-nti jt-nti assigned jt-nti and unassigned lquintai Jan 13, 2022
@jt-nti
Copy link
Contributor

jt-nti commented Jan 13, 2022 •
edited
Loading

We should probably do an audit fix!

Definitely!

@jt-nti jt-nti removed the blocked label Jan 13, 2022
@jt-nti jt-nti added the p1 label Mar 2, 2022
@jt-nti jt-nti removed their assignment Dec 13, 2022
@jt-nti jt-nti added the wontfix This will not be worked on label Dec 13, 2022
@jt-nti
Copy link
Contributor

jt-nti commented Dec 13, 2022

See #3183

@jt-nti jt-nti closed this as completed Dec 13, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
build p1 wontfix This will not be worked on
Projects
None yet
Milestone
Sprint 44
3 participants
@jt-nti @Jakeeyturner @lquintai