-
Notifications
You must be signed in to change notification settings - Fork 42
dist naming inconsistancies #23
Comments
Here are the discrepancies in file names between the PNG and SVG folders.
|
Here are some file names that just strike me as odd. I'm not sure about how to change some of them, but I figured I should point them out. These changes aren't required at all, because the names are consistent between SVG/PNG folders.
Here are the patterns I was using to see if the file names sounded good or not:
|
@hchughes should weigh in on this...the naming has impact on the way the files show on the site, if i'm not mistaken. |
@slapjack7 all of the file naming conventions will come from the illustrator art boards which @hchughes had a say in. There were problems doing manual exports of all 877 icons (if you can possibly imagine) and they should be fixed and contestant in the 2.0.0 release. I'm working hard to balance getting that release out with the rest of my day job. If you would like to help. I welcome prs! https://github.com/IBM-Design/icons/issues?q=is%3Aopen+is%3Aissue+milestone%3A2.0.0 |
Hi @mbarlock - the names that are on the site itself are the names of the icons, full stop. The names of the most recent glyphs should match 1-to-1 with the corresponding icons they relate to. http://www.ibm.com/design/language/resources/icon-library |
@jhnsnc If these are recommended changes to the names of 9 or so of them, I'm happy to look them over today and get back to you all on those. |
Gotcha, thats easily not true right now 😛. All of the names will be coming from the names of the individual art boards that @poofichu is making ( ❤️ ). Before I push |
Great. And to be clear, the "recommended" column is my personal opinion. I did not reference the IBM Design Language site. |
Should be easy to automate, generate, and validate. |
Already done! I missed closing this. All the icons align with what is in the icon library |
Fixed by #33 |
|
The microphone-recording icon only exists as a png.
The text was updated successfully, but these errors were encountered: