Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] The S3 secret name is hardcoded in the KFP library #985

Open
2 tasks done
roytman opened this issue Jan 28, 2025 · 0 comments
Open
2 tasks done

[Bug] The S3 secret name is hardcoded in the KFP library #985

roytman opened this issue Jan 28, 2025 · 0 comments
Labels
bug Something isn't working

Comments

@roytman
Copy link
Member

roytman commented Jan 28, 2025

Search before asking

  • I searched the issues and found no similar issues.

Component

Library/kfp

What happened + What you expected to happen

Due to kubeflow/pipelines#10914, we cannot provide secret names as pipeline arguments, so we agreed to a workaround that the secret name will be hard-coded.
The secret names should be in pipeline, so users will be able to overwrite them. Currently it is in the library, so users cannot change it.

Reproduction script

.

Anything else

No response

OS

Red Hat Enterprise Linux (RHEL), Ubuntu

Python

3.11.x

Are you willing to submit a PR?

  • Yes I am willing to submit a PR!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant