Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

<Feature> Add a pass dependency in the rule engine #2050

Open
shunguoy opened this issue Sep 13, 2024 · 1 comment
Open

<Feature> Add a pass dependency in the rule engine #2050

shunguoy opened this issue Sep 13, 2024 · 1 comment
Labels
engine Issues in the accessibility-checker-engine component enhancement New feature or request T63

Comments

@shunguoy
Copy link
Contributor

shunguoy commented Sep 13, 2024

The current rule engine has a fail dependency, in which a rule won't be triggered if any of the dependent rules fail. In other cases, a pass dependency check is needed to ignore a rule if a dependent rule passes. This is for the rules that target the same or similar area (e.g., focus) but with different logic.

For example, ignore the element_tabbable_role_valid rule if the element_scrollable_tabbable rule passes. Otherwise, conflict results would occur. see https://ibm-studios.slack.com/archives/C036P1CTN/p1726218784246219

@shunguoy shunguoy changed the title Add a Pass Dependency in the rule engine Add a pass dependency in the rule engine Sep 13, 2024
@shunguoy shunguoy added T63 engine Issues in the accessibility-checker-engine component enhancement New feature or request labels Sep 13, 2024
@shunguoy shunguoy changed the title Add a pass dependency in the rule engine <Feature> Add a pass dependency in the rule engine Sep 13, 2024
@shunguoy
Copy link
Contributor Author

Triage: currently we use functions to do so with caching. The change can be significant.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
engine Issues in the accessibility-checker-engine component enhancement New feature or request T63
Projects
None yet
Development

No branches or pull requests

1 participant