Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Marker parameters: discrepancies -> exclude probably not working #85

Open
dweindl opened this issue Jan 16, 2025 · 0 comments · May be fixed by #87
Open

Marker parameters: discrepancies -> exclude probably not working #85

dweindl opened this issue Jan 16, 2025 · 0 comments · May be fixed by #87
Assignees
@dweindl
Labels
bug Something isn't working

Comments

@dweindl
Copy link
Member

dweindl commented Jan 16, 2025

Toggling the marker option exclude may lead to unexpected results, due to a typo here:

https://github.com/DTSHaas/C-COMPASS/blob/5956cf8fbb830e7a1e01faa3ad507c1a2f5e2007/CCMPS/PPMS.py#L238-L239
@dweindl dweindl added the bug Something isn't working label Jan 16, 2025
@dweindl dweindl self-assigned this Jan 16, 2025
@dweindl dweindl changed the title Marker parameters: discrepancies -> exclude probably not working Marker parameters: discrepancies -> exclude probably not working Jan 16, 2025
dweindl added a commit that referenced this issue Jan 16, 2025
@dweindl
Fix marker option: discrepancies -> exclude
311913d 
Most likely, so far, this option didn't work as expected due to a typo.

Closes #85.
@dweindl dweindl linked a pull request Jan 16, 2025 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dweindl dweindl

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix marker option: discrepancies -> exclude ICB-DCM/C-COMPASS
1 participant
@dweindl