Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Overflow when creating data if tile size is large #645

Closed
QingleiCao opened this issue Mar 13, 2024 · 1 comment
Closed

Overflow when creating data if tile size is large #645

QingleiCao opened this issue Mar 13, 2024 · 1 comment
Assignees
@QingleiCao
Labels
bug Something isn't working
Milestone
v4.0

Comments

@QingleiCao
Copy link
Contributor

Here, matrix->bsiz and parsec_datadist_getsizeoftype are integers, which may lead to overflow when the tile size is large. This case is encountered in a case where the tile size is L * (L^2/2) (L = 720) and the datatype is double complex.

Do we need to use size_t to protect here or bsiz in parsec_tiled_matrix_t?
@QingleiCao QingleiCao added the bug Something isn't working label Mar 13, 2024
@QingleiCao QingleiCao mentioned this issue Mar 15, 2024
Merged
@abouteiller abouteiller added this to the v4.0 milestone Apr 24, 2024
@QingleiCao
Copy link
Contributor Author

#646

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@QingleiCao QingleiCao

Labels
bug Something isn't working
Projects
None yet
Milestone
v4.0
Development

No branches or pull requests
2 participants
@abouteiller @QingleiCao